2780 Commits

Author SHA1 Message Date
Peter Serwylo
938c992023 Comment out tests for future, desirable behaviour.
Leave only the ones which align with the current multi-repo behaviour
that F-Droid exhibits.

The commented out tests can be uncommented in the future when working
on proper multi-repo support.
2015-11-07 08:05:13 +11:00
Peter Serwylo
1c179848b7 Added tests for current multi-repo behaviour.
This is the bare minimum of what must be maintained going forward.
Ideally the behaviour sohould be better, but that is for the future.
2015-11-07 08:05:13 +11:00
Peter Serwylo
0685c16efe More work on multi-repo tests, currently broken due to F-Droid being broken.
(One of) the problems with F-Droid's multiple support is that there is
a primary key on the fdroid_apk table which is a composite of:

 * id
 * vercode

Which means that two repos providing the same version means one will
update the other, rather than ending up with two different versions.

Instead, there should be some other way to differentiate apks from
different sources. Firstly, it should take into account the signing
cert. Secondly, it may taken into account the hash, because two people
could sign different apks with the same cert and then we are back at
square one.
2015-11-07 08:05:13 +11:00
Peter Serwylo
f794d1e7a5 Infrastructure for doing test driven development to support multiple repo dev.
The new test skeletons right now update three different repos
in different configurations. They do so such that the order of updates
changes and therefore the way in which conflicts between repos are
dealt with are tested.

They should all have the same result (though I'm not sure exactly what
that should be yet).
2015-11-07 08:05:13 +11:00
Peter Serwylo
8d1e20b7fd Remove TargetApi(8) because that is our min-sdk now. 2015-11-07 08:05:13 +11:00
Peter Serwylo
b6218c6d05 Refactored code which inserts apps into database to make testable.
Putting it in the UpdateService made it a little tricky to test, so
I moved it out to a separate class called `RepoPersister`.
2015-11-07 08:05:13 +11:00
F-Droid Translatebot
c6a8bd2139 Pull translation updates from Weblate
Translators:

Dimos D            Greek
Dmitry Mikhirev    Russian
Michalis           Greek
Szöllősi Attila    Hungarian
2015-11-05 12:06:14 +01:00
Daniel Martí
c74e272de7 Bump build-tools to 23.0.2 2015-11-05 12:00:42 +01:00
Daniel Martí
6483106a46 Merge branch 'category-filter-height' into 'master'
Set category filter height to 48dp

This improves usability of the category spinner. Divider is now behind
it. This makes the layout visually more compact while keeping actual
touch target 48dp. See
http://www.google.com/design/spec/layout/metrics-keylines.html#metrics-keylines-touch-target-size

Before and after:

![before](/uploads/b52b3c84675c8b3ef5896e90967dafd4/before.png)
![after](/uploads/a07efee75bdfe5356378fa9960da8730/after.png)


See merge request !161
2015-11-05 10:16:38 +00:00
relan
0bd995a731 Set category filter height to 48dp
This improves usability of the category spinner. Divider is now behind
it. This makes the layout visually more compact while keeping actual
touch target 48dp. See
http://www.google.com/design/spec/layout/metrics-keylines.html#metrics-keylines-touch-target-size
2015-11-05 11:56:18 +03:00
Daniel Martí
d242440fe3 Fix all InlinedApi lint warnings 2015-11-01 20:16:31 +01:00
Daniel Martí
ca9e390e60 lint: ignore UnusedAttribute 2015-11-01 20:09:31 +01:00
Daniel Martí
81db276f8d Avoid showAsAction=always whenever possible
In AppDetails, work around it by using ifRoom and placing that button
first so that it gets preference. The rest aren't affected at all.
2015-11-01 20:06:17 +01:00
Daniel Martí
6db5da2cf7 Fix string formatting issues found by lint 2015-11-01 19:54:37 +01:00
F-Droid Translatebot
c5a36f34f2 Pull translation updates from Weblate
Translators:

agilob                   Polish
Allan Nordhøy            Norwegian Bokmål
Kiril LastName           Bulgarian
Kristoffer Grundström    Swedish
Mladen Pejaković         Serbian
2015-11-01 19:49:07 +01:00
Daniel Martí
41d2c69d2e Remove unused ic_info_white drawable
The layout code that uses it is now commented out. This commit can be
reverted once the layout code is used again in the future.
2015-11-01 19:43:45 +01:00
Daniel Martí
41fbbd9825 Exclude more license/notice files from apk
This reduces the final apk size by an additional 5KB.
2015-11-01 19:38:29 +01:00
Daniel Martí
04e8117c3e Bump to 0.97-alpha8 v0.97-alpha8 2015-10-31 10:12:07 +01:00
F-Droid Translatebot
079e704375 Pull translation updates from Weblate
Translators:

Anders Jonsson           Swedish
Kristoffer Grundström    Swedish
Mladen Pejaković         Serbian
2015-10-31 10:09:53 +01:00
Daniel Martí
7c2b7ef280 checkstyle fix 2015-10-31 10:09:23 +01:00
Daniel Martí
4bfae52a9e Merge branch 'privileged-extension-icon' into 'master'
New icon for Privileged Extension

Align Privileged Extension icon with current F-Droid icon. The # sign is associated with privileges because it's usually used by root shell. Lego blocks that can be plugged into each other are also known very well around the world.

"F-Droid Privileged Extension icon" by @relan is licensed under CC-BY-SA 3.0 or GPLv3+.

Smaller size:

![privileged-small](/uploads/5af03c7d7e7c50f3669b72f2c913c08f/privileged-small.png)

Larger size:

![privileged-large](/uploads/9408b31a92e154e1e8a9cd3953889d94/privileged-large.png)

Raster images are optimized using `optipng -o7 -zm1-9`.

See merge request !155
2015-10-29 15:43:20 +00:00
Daniel Martí
b4560fc217 Merge branch 'materialize-category-filter' into 'master'
Make category filter look Material

Get rid of Gingerbred legacy.

Before and after (note the glitch below the spinner):

![before](/uploads/b0ed14216dcd772a78e3efc8ea8295f0/before.png)
![after](/uploads/0fba2177b33a2061ab67534a73de3f90/after.png)


See merge request !159
2015-10-29 15:41:58 +00:00
Daniel Martí
501d3d3176 Merge branch 'darker-dark-theme' into 'master'
Use darker primary colors for the Dark theme

Primary colors of the Light theme are too bright for the Dark theme. The difference should be especially noticeable on OLED screens.

Before and after:

![before](/uploads/437920c0b1173522b3d8312740532d12/before.png)
![after](/uploads/e1fa004e35021152688ba5b0da4d7086/after.png)

See merge request !160
2015-10-29 15:40:09 +00:00
relan
96091b00d5 Use darker primary colors for the Dark theme
Primary colors of the Light theme are too bright for the Dark theme.
2015-10-29 18:26:39 +03:00
Daniel Martí
214fd32552 Update changelog for 0.97 2015-10-29 16:18:41 +01:00
relan
9170e2af91 Make category filter look Material
Get rid of Gingerbred legacy.
2015-10-29 18:15:01 +03:00
Daniel Martí
2c1b13620f Disable DownloadManager usage for stable
Since it's unstable and introduces regressions. See #445 and #459, for
example.
2015-10-29 16:11:08 +01:00
Daniel Martí
6c8e726aad Revert netcipher to fix SNI regression
Fixes #431.
2015-10-29 16:08:17 +01:00
F-Droid Translatebot
dd0f9dcccf Pull translation updates from Weblate
Translators:

ageru                 French
agilob                Polish
Ajeje Brazorf         Sardinian
Dario Tordoni         Italian
Laura Arjona Reina    Spanish
Ldm Public            French
naofum                Japanese
Osoitz                Basque
Sérgio Marques        Portuguese (Portugal)
2015-10-29 16:05:01 +01:00
relan
e599300620 New icon for Privileged Extension 2015-10-27 09:39:00 +03:00
Daniel Martí
92713acdce Fix tests after e085e039
We already had a getPackageInfo, but it wasn't the proper one with flags so
that our new code could use it.
2015-10-25 13:13:55 +01:00
Daniel Martí
42b6176cff AppSecurityPermissions: cleanup
Mostly removing obsolete comment from the original source. Also removing some
unnecessary C-style for loops.
2015-10-23 16:40:48 +02:00
Daniel Martí
e085e0392b PackageReceiver: Only fetch the one PackageInfo
We were fetching information on all installed packages and doing a linear
search. Which is silly and inefficient since we can directly fetch information
on a single installed package by id.
2015-10-23 13:21:56 +02:00
Daniel Martí
1a4c2ca408 Remove unnecessary variable initializations 2015-10-23 13:11:18 +02:00
Daniel Martí
927e05ba8d Take some final declaration suggestions from AS 2015-10-23 13:08:24 +02:00
Daniel Martí
7f2efc7267 Take some declaration access suggestions from AS 2015-10-23 13:06:23 +02:00
Daniel Martí
97eea866aa Remove unused class fields 2015-10-23 13:01:10 +02:00
Daniel Martí
1ad69adf4e Explicit catch ignores to make linters happy 2015-10-23 12:58:51 +02:00
Daniel Martí
0bb921adad Optimize imports 2015-10-23 12:55:09 +02:00
Daniel Martí
9475d1634c AppDetails: Remove another extra getPackageManager() 2015-10-23 12:44:31 +02:00
Daniel Martí
da6fd323fd Remove unnecessary initializers
These fields are initialized to their zero values (0, null, false) so doing
the same over in the constructor is unnecessary.
2015-10-23 12:41:05 +02:00
Daniel Martí
56d9ccd737 Deduplicate getApp() getter madness
Not that it's any more efficient, but it's surely more readable.
2015-10-23 12:35:05 +02:00
Daniel Martí
8b114326f5 AppDetails: Remove unnecessary Signature
Mainly since in the future we'll only have the hash of it, so avoid depending
on the object.
2015-10-23 12:31:05 +02:00
Daniel Martí
960b67e950 AppDetails: Remove extra getter 2015-10-23 12:25:20 +02:00
Daniel Martí
d32c866bb4 Bump to 0.97-alpha7 v0.97-alpha7 2015-10-23 11:01:04 +02:00
F-Droid Translatebot
04e548aec4 Pull translation updates from Weblate
Translators:

Ajeje Brazorf                     Sardinian
Allan Nordhøy                     Norwegian Bokmål
Daniel Martí                      Catalan
Luiz Wagner Tavares Nascimento    Italian
Marcelo Santana                   Portuguese (Brazil)
relan                             Russian
2015-10-23 10:59:58 +02:00
Daniel Martí
35acb141c9 Ignore upstreamVercode if it doesn't work
If it doesn't result in any version being marked as suggested, e.g. because it
is higher than 0 but lower than any available version, we end up with a NULL
suggestedVercode.

Run the Latest() algorithm after the Upstream() one, and have it pick up those
cases too by adding "OR suggestedVercode IS NULL". This way, we treat invalid
upstreamVercode values as if they were NULL.

Also some cleanup of comments.

Fixes #371.
2015-10-22 16:58:38 +02:00
Daniel Martí
fb3b0a0281 Comment indenting fix 2015-10-22 00:25:19 +02:00
Daniel Martí
adca9a051b Checkstyle fixes 2015-10-22 00:13:17 +02:00
Daniel Martí
30b6d6df90 Don't hardcode preference keys 2015-10-22 00:10:18 +02:00