3855 Commits

Author SHA1 Message Date
Hans-Christoph Steiner
9b61dfdcb4 fix emulator tests on android-10, closes #769
We have to work harder to get writeable dirs in the android-10 emulator.
2016-10-25 11:54:40 +03:30
uberspot
a183da42b6 Remove any whitespace from fingerprint EditText input so that copy pasting is easier for users. 2016-10-25 11:54:40 +03:30
Daniel Martí
6844b31884 Bump build-tools and docker image version
The latter is simply to include the newer version.
2016-10-25 11:54:40 +03:30
Daniel Martí
6ba260b07b Add new Burmese/Myanmar language to the list
Rendering this on my computer is a pain, so patches welcome if I screwed
up the unicode since all I can see is squares.
2016-10-25 11:54:40 +03:30
F-Droid Translatebot
977f0fe747 Pull translation updates from Weblate
Translators:

Agus                      Galician
Ajeje Brazorf             Sardinian
Alberto Moshpirit         Spanish
El Virolo                 French
Koen Glotzbach            Dutch
Licaon Kter               Romanian
Michael                   German
Mohamad Hasan Al Banna    Indonesian
naofum                    Japanese
Olexandr Nesterenko       Ukrainian
Osoitz                    Basque
Pyae Sone                 Burmese
Verdulo                   Esperanto
Verdulo                   Polish
YFdyh000                  Simplified Chinese
2016-10-25 11:54:40 +03:30
F-Droid Translatebot
0133854ad6 Pull translation updates from Weblate
Translators:

Adrià García-Alzórriz    Catalan
Ajeje Brazorf            Sardinian
Christophe CHAUVET       French
Enol P                   Asturian
Laura Arjona Reina       Spanish
Licaon Kter              Romanian
Michael                  German
Mladen Pejaković         Serbian
naofum                   Japanese
Osoitz                   Basque
Swyter                   Spanish
Sylvia van Os            Dutch
Tobias Bannert           German
Verdulo                  Esperanto
Verdulo                  Polish
Viktor Alojzije Coric    Croatian
Waqar Ahmed              Urdu
YFdyh000                 Simplified Chinese
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
1e26e31309 privileged mode means auto-downloads are actually installs
When the Privileged Extension is working, then enabling the preference
"Automatically download updates" will actually install those updates in the
background.  So the preference should communicate that to the user. So now
it serves as a global "allow background updates"

#16
closes #106
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
4b922f38b9 don't show notification if the app name is unknown #720
This gets rid of the notifications that say "Tap to Install Unknown", and
instead just cancels the notification.  The downloaded APK will still be
cached, so when the user goes to click install or update again, it won't
need to download it again.

closes #758
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
5b46303961 handle install broadcasts after InstallManagerService was killed
If InstallManagerService was killed, it'll forget all of its state.  If it
is killed while an install process is running, and that install fails,
InstallManagerService will receive a broadcast about the error but then it
can't find anything about the app in question besides its download URL.
That is enough to control the notification, but not enough to get the name
of the app in question.  This is a workaround by showing the APK filename
when the app name cannot be found. Ideally, the packageName would somehow
magically be delivered to InstallManagerService in this case, but the
Installer stuff doesn't always have it to send.

With android-23, there is getActiveNotifications(), which we might be able
to use to stash the packageName and fetch it as needed.
2016-10-25 11:54:40 +03:30
Aditya Bharadwaj
9ca20395be Fix PMD issue. 2016-10-25 11:54:40 +03:30
Aditya Bharadwaj
1688adc0d4 Update naming convention as per review. Add antifeatures list length check to filter anti-feature apps. 2016-10-25 11:54:40 +03:30
Aditya Bharadwaj
7997e707d8 Fix checkstyle issue. 2016-10-25 11:54:40 +03:30
Aditya Bharadwaj
6e90be7b68 Add option to grey out apps requiring anti-features. 2016-10-25 11:54:40 +03:30
Daniel Martí
81b0eacd9f Bump to 0.101-alpha6 2016-10-25 11:54:40 +03:30
F-Droid Translatebot
ba26228dce Pull translation updates from Weblate
Translators:

Ajeje Brazorf    Sardinian
John Doe         Turkish
Nathan Follens   Dutch
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
8d8400449e get ACRA reports without crashing to debug #698
This should be reverted once #698 is fixed.  If execution has gotten this
far into InstallManagerService, there should always be App and Apk
instances.  That is enforced when Intents are received by this Service.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
1d5dcb76a2 remove confusing messages when Privileged Extension not installed
This was saying that the Privileged Extension is enabled but not properly
configured.  This is because the preference logic changed to default to on
unless the user explicitly disabled it.  So using the Privileged
Extension based on whether its installed and whether the user has disabled
it.

related to ea0700d406101b7ed6907b1dbd2918dbc214f435
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
2d25ef53f5 update support libs to latest (24.2.0) to hopefully fix crashes
Based on ACRA reports, there are some mystery UI related stacktraces that
do not have org.fdroid.fdroid lines in them.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
f888d9e5fc use gradle-witness for all included libs
use the automatic method for generating the gradle-witness block so its
easy to keep it updated.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
ce928e40fa sort gradle-witness lines so its easy to see changes 2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
9db47da42b check whether installed APKs exist and are readable before hashing
I guess APKs could disappear, or perhaps not be readable.

closes #699

Here's the stacktrace:

java.io.FileNotFoundException:
 /system/priv-app/ATT_Ready2Go/ATT_Ready2Go.apk: open failed: ENOENT (No such file or directory)
 at org.fdroid.fdroid.Utils.getBinaryHash(Utils.java:405)
 at org.fdroid.fdroid.data.InstalledAppProviderService.onHandleIntent(InstalledAppProviderService.java:164)
 at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
 at android.os.Handler.dispatchMessage(Handler.java:102)
 at android.os.Looper.loop(Looper.java:135)
 at android.os.HandlerThread.run(HandlerThread.java:61)
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
5c18cead1c update changelog
closes #752
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
e65706971e use Privileged Extension by default when it is installed
This totally changed the logic of the "Use Privileged Extension" preference
making it based on whether the Privileged Extension is installed and usable
rather than storing the user's selection.  This code now only stores when
the user manually disables using the Privileged Extension even when it is
installed.

closes #729
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
9b07167430 only show "install Priv Ext" in Prefs when its supported
The root install method that is available via the "Expert" preferences does
not work on newer than android-19.  So when that's the case, this hides
that item from the preferences screen entirely.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
010574c0ce gitlab-ci: require emulator tests pass on android-24 2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
2158afcc9d fix bug in cache cleanup on 21+ introduced in cbd6da5
!379 was merged without the emulator tests passing.  This fixes that.
2016-10-25 11:54:40 +03:30
Daniel Martí
8a1a2fa310 Bump robolectric to 3.1.2 2016-10-25 11:54:40 +03:30
Daniel Martí
a0b56b23ca gradle: bump plugin and wrapper version
Since the new plugin requires 2.14.1 for security reasons.

Also re-run `gradle wrapper` to update the scripts and the jar.
2016-10-25 11:54:40 +03:30
Daniel Martí
3a1c6612c0 CI: bump image 2016-10-25 11:54:40 +03:30
Daniel Martí
f26768a77c Bump to 0.101-alpha5 2016-10-25 11:54:40 +03:30
F-Droid Translatebot
6b89201d93 Pull translation updates from Weblate
Translators:

Kristjan Räts    Estonian
Marko            Finnish
tacsipacsi       Hungarian
2016-10-25 11:54:40 +03:30
Peter Serwylo
c76c920397 Move code causing verify error into separate helper class
I'm not 100% sure on how the `@TargetApi` and `VerifyError` work
together. However it is something along the lines of:
 * Class loader needs `CleanCacheService`.
 * At this point, it loads the bytecode for that class and verifies
   that it all makes sense.
 * The bytecode within the method targeted at API 21 is not understood
   by earlier APIs, because the entire `Os` class was introduced in 21.
 * By putting it into a different class, that class is only loaded
   at runtime on devices with API of 21 or higher.

Previously, `@TargetApi` + the relevant guard condition to check
the build version at runtime suffices to prevent this. However it seems
that if the entire class does not even exist on earlier APIs, then it
is no longer good enough.
2016-10-25 11:54:40 +03:30
Peter Serwylo
c02cc41c2f Ensure that description is not null when parsing index.
At time of writing (and for some time before), fdroidserver has forced
a description of "No description available" for apps which don't have
descriptions at all:

 * https://gitlab.com/fdroid/fdroidserver/blob/0.6.0/fdroidserver/metadata.py#L876

However, if the description is not set for whatever reason, it should not
crash the client.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
fe35343a36 document processes in CleanCacheService
This breaks out each separate process into its own utility method, and adds
javadoc to describe them.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
3944747766 delete cached icons that have not been accessed in over a year
The icon files are downloaded for each version of the app.  Over time, old
versions will pile up.  This cleans out the ones that have not been used in
over a year.

On < android-21, this will delete icons that were downloaded over a year
ago even if they are still in use because it is only possible to check
mtime, not atime.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
d1eb5b5fb3 avoid deleting cached files while they are being used
If CleanCacheService runs while an APK is being installed, it should not
delete the APK that is in the process of being installed.  This does that
by only deleting those files if they are older than an hour. Same goes for
the index files.

#738
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
6046af5328 fix bug where files were never deleted from cache
It was passing the wrong time value in the recursion, which made for a
really old "olderThan" time.  This also then flipped the logic on the
next round through the recursion, causing files to be deleted even if
"Keep Cache Time" was set to "Forever".

closes #719
closes #736
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
aa39d7bc7f if the "Keep Cache Time" pref changes, reschedule CleanCacheService
Before, CleanCacheService was only scheduled at app start for once a day.
If the user selects a time less than a day, then CleanCacheService should
run more frequently.

closes #719
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
bb0e84c509 clearOldFiles() test must run on the emulator
It seems that Robolectric does not implement android.system.Os so the
atime checking code cannot be tested there.  Works fine on the emulator.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
db6214dcc5 switch "Keep Cache Time" units to milliseconds
Both the Android task scheduler and the Java File operations want millis.
For "Forever", Long.MAX_VALUE is used.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
91b4072c1a move clearOldFiles() to CleanCacheService to be used on other files
Now that there is the ability to remove files based on last access time, it
makes sense to use this on all cached files, including icons, etc.
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
5911e34b43 use access time to remove old cache files >= android-21
In android-21, they exposed the formerly internal method for getting stat
structs of files.  From that, we can get the last access time, which is a
much better way to determine which files to delete rather than last
modified time.

closes #644
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
926c3a6c01 set default for "keep cached apps"
There was no default set in the XML, so it just showed the default as blank

closes #719
2016-10-25 11:54:40 +03:30
Daniel Martí
4d67298f38 values-et: fix format errors from weblate 2016-10-25 11:54:40 +03:30
F-Droid Translatebot
2a1fba445f Pull translation updates from Weblate
Translators:

Danial Behzadi    Persian
Kristjan Räts     Estonian
tacsipacsi        Hungarian
2016-10-25 11:54:40 +03:30
Hans-Christoph Steiner
fe7e299df9 Utils.getBinaryHash() should not catch exceptions
By catching the exception here and returning null, the problem is then
passed on further down the line where it is harder to debug.  The hash is
required wherever this method is called, so this should fail immediately.

#699
2016-10-25 11:52:49 +03:30
Hans-Christoph Steiner
d174ea8d3e standardize on lowercase SHA-256 hashes
fdroidserver produces lowercase hashes, so its easiest to just mimic
that.  This makes hash comparisons easy.
2016-10-25 11:52:49 +03:30
Hans-Christoph Steiner
bc19a72de5 standardize priv-app install name as FDroidPrivilegedExtension
This syncs up the name the root install method uses with what is used by
the ROM integration and update.zip.  It also uses the full name for
consistency, with non-alpha and spaces removed following priv-app naming
conventions.

https://gitlab.com/fdroid/privileged-extension/merge_requests/3
https://gitlab.com/fdroid/privileged-extension/merge_requests/5
2016-10-25 11:52:49 +03:30
Hans-Christoph Steiner
9eaf601f61 remove scripts for creating update.zip, moved to priv-ext
https://gitlab.com/fdroid/privileged-extension/merge_requests/5
2016-10-25 11:52:49 +03:30
Hans-Christoph Steiner
f55e5480cf gitlab-ci: another gradle bit to delete for good caching
recommended here, seems like it can't hurt:
https://docs.travis-ci.com/user/languages/java/#Caching
2016-10-25 11:52:49 +03:30