2357 Commits

Author SHA1 Message Date
Peter Serwylo
645f9fc5e3 Rename Utils.copy and Utils.symlinkOrCopyFile to indicate exception clobbering
Renamed to Utils.copyQuietly() and Utils.symlinkOrCopyFileQuietly().

The copy(File, File) method gobbles up IOExceptions, whereas the other
copy(InputStream, OupputStream) method doesn't. This could cause confusion,
whereas developers using one may not realise it is is gobblign their
exceptions.
2015-09-10 06:22:29 +10:00
Peter Serwylo
a09587c7e2 Use helper functions where appropriate. 2015-09-10 06:21:12 +10:00
Peter Serwylo
7b773f94f9 Make DownloadManager code file-agnostic, needn't be specific to "Apps"
This is mainly cosmetic, changing the names of variables so that the downloader
can seemingly be used for any type of download into the future.
2015-09-10 06:21:12 +10:00
Peter Serwylo
0a9941d93d Refactor AsyncDownloader to be an interface.
The interface is used by both AsyncDownloadWrapper and
AsyncDownloaderFromAndroid.
2015-09-10 06:21:12 +10:00
Peter Serwylo
d0d287f668 Remove undocumented params from JavaDoc.
Android Studio by default warns about undocumented params, which makes it harder
to identify more problematic warnings to do with actual code problems. This warning could
be toned down in the IDE so that it doesn't complain, but equally, the params are
not neccesary in JavaDoc if they are undocumented, and don't end up adding any more
than the parameters themselves.
2015-09-10 06:21:12 +10:00
Peter Serwylo
69ecaf023f Refactored AsyncDownloader to only ever be constructed by DownloadFactory. 2015-09-10 06:21:12 +10:00
Peter Serwylo
9b7c4c7b4a WIP: CR. 2015-09-10 06:21:11 +10:00
Toby Kurien
ef40b5f3db Now displays a notification when download is complete, unless use is already on the app details screen, in which case it pops up the installer immediately 2015-09-10 06:21:11 +10:00
Toby Kurien
13e54ced07 Display of app name and version in the download title 2015-09-10 06:21:11 +10:00
Toby Kurien
6f8b49c974 proper handling of file resources, implemented progress stats for async downloader 2015-09-10 06:21:11 +10:00
Toby Kurien
d10a56ed44 re-inserted log statement mistakenly removed 2015-09-10 06:21:11 +10:00
Toby Kurien
f3ef78d292 reverted to previous version, for merge request. 2015-09-10 06:21:11 +10:00
Toby Kurien
efd4ebeadf cleaned up code, prevented multiple app details screens popping up, fixed "no such app" toast after install 2015-09-10 06:21:11 +10:00
Toby Kurien
e827be1b5b when user clicks on notification, the app details screen now comes up. If there are multiple downloads, the first one is shown. 2015-09-10 06:21:11 +10:00
Toby Kurien
8a7feba9cc drastically speed up debug build by not minifying and compressing resources. Release builds unaffected. 2015-09-10 06:21:11 +10:00
Toby Kurien
11caf22dc6 wip: app details now reloads details of running downloads 2015-09-10 06:21:11 +10:00
Toby Kurien
f9fee5beb0 wip: when a download is completed, app is woken up and app details screen displayed 2015-09-10 06:21:11 +10:00
Toby Kurien
5f989739bb wip: running download manager outside fdroid 2015-09-10 06:21:10 +10:00
Toby Kurien
dbd4c467f8 added asyndownloader to use DownloadManager when possible 2015-09-10 06:21:10 +10:00
Hans-Christoph Steiner
13c90e6c4a add HTTPS pins for good, free CAs: cert.startcom.org & letsencrypt.org
These are two good options for easy, free HTTPS certificates.  This should
help, but not fix, #238 https://gitlab.com/fdroid/fdroidclient/issues/238
2015-09-08 19:21:24 +02:00
Hans-Christoph Steiner
2c88703588 use NetCipher to get improved TLS and cipher support on HTTPS connections
The NetCipher library creates instances of HttpURLConnection that are
configured to have solid TLS protocol and cipher settings, especially on
older versions of Android.

fixes #370 https://gitlab.com/fdroid/fdroidclient/issues/370
2015-09-08 19:19:30 +02:00
Hans-Christoph Steiner
853e281710 code formatting fixes for build.gradle from Android Studio 2015-09-08 19:19:29 +02:00
Hans-Christoph Steiner
1f607d3e6d improve net check for index updates; update index on app start
This remove the magic number "1" from the network state check, and makes
explicit that it is checking the active network connection.

This is then used to check whether it is appropriate to update the index
when FDroid first starts.
2015-09-08 19:19:29 +02:00
Daniel Martí
cba103af77 Start changelog for 0.97 2015-09-08 10:18:27 -07:00
Daniel Martí
50cd629d7d Bump to 0.97-alpha1 v0.97-alpha1 2015-09-06 00:34:23 -04:00
Daniel Martí
9e85911b5d StrictMode fix: close cached keystore file 2015-09-05 23:45:45 -04:00
Daniel Martí
cb9290fb89 Detect all VM policy penalties 2015-09-05 23:35:39 -04:00
Daniel Martí
8b7eba6698 StrictMode fix: close streams in local repo assets 2015-09-05 23:31:19 -04:00
Daniel Martí
bd1db5412b Add StrictMode to the entire app, fixes #399
Only enabled on debug builds. With only logs for now, we can move on to more
annoying penalties like dialogs or crashes once we have solved all of them.
2015-09-05 23:30:59 -04:00
Daniel Martí
232ed2229b Bump build-tools 2015-09-05 23:00:47 -04:00
Daniel Martí
6214b7f659 Merge branch 'issue-395' 2015-09-05 22:16:15 -04:00
Daniel Martí
45782355db Update zxing-core to 3.2.1 2015-09-05 22:14:18 -04:00
Peter Serwylo
3213fd2ba1 Merge branch 'new-swap' 2015-09-06 08:37:26 +10:00
Hans-Christoph Steiner
9cb8e0f5d5 Merge branch 'ci-rootproject' into 'master'
CI: use root project, test fix

See merge request !130
2015-09-04 12:37:12 +00:00
Daniel Martí
2fda08a33e Remove duplicated spaces from strings 2015-09-03 22:03:07 -07:00
Daniel Martí
10171d9228 Installer: handle package parse errors, fixes #395 2015-09-03 18:52:40 -07:00
Daniel Martí
74c93907c5 Don't call onAppChanged() if install was cancelled
It should have not changed anything about the app. It should make AppDetails
update anything as needed just like returning from any other activity.
2015-09-03 18:49:31 -07:00
Daniel Martí
16a0344ceb Update RepoXMLHandlerTest to make tests pass 2015-09-03 18:02:57 -07:00
Daniel Martí
c725b36ff8 Move RepoXMLHandlerTest into the proper directory
This was probably due to a faulty rebase/merge.
2015-09-03 18:02:57 -07:00
Daniel Martí
6821254aeb README fixes
* Don't suggest assembleDebug for building
* Use connectedCheck for tests like the CI
* Don't split links for readability
2015-09-03 18:02:54 -07:00
Daniel Martí
9106fb1321 CI: Run build and connectedCheck in the root
This will make sure that all projects in the repository are built and tested.
Should come in handy for !126, which splits up the app into two apps and one
library.
2015-09-03 17:18:24 -07:00
Daniel Martí
e72ccd3012 Bump to 0.97-alpha0 2015-09-02 17:54:55 -07:00
Daniel Martí
24c3ebbf57 README: mention stable branching and -alpha0 2015-09-02 17:54:55 -07:00
Daniel Martí
77bb9dbed8 Update changelog for 0.96 2015-09-02 17:54:55 -07:00
Daniel Martí
7ae6c38e9a Merge branch 'ci-emulator-tests' into 'master'
CI: run Android tests in an emulator

See #400. Using a WIP merge request to be able to test things on the CI.

See merge request !129
2015-09-02 23:28:32 +00:00
Daniel Martí
c43505befb Fix tests by making a method explicitly protected
This was making proguard complain and refuse to continue. This fix should not
alter how F-Droid works, it's just to make the tests function with proguard
enabled.
2015-09-02 16:10:06 -07:00
Daniel Martí
582eebd436 Run connectedAndroidTest against an emulator
Using 2.3.7 (10) armeabi for now. We can look into using more images in the
future.
2015-09-02 12:59:59 -07:00
Peter Serwylo
f635df8502 Merge branch 'master' into new-swap 2015-09-02 17:01:58 +10:00
Daniel Martí
ab1ec07686 Add platform-tools and build-tools to PATH 2015-09-01 21:43:26 -07:00
Daniel Martí
1fcc1dae1c CI: split up package installing 2015-09-01 15:45:13 -07:00