Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Appease pmd

Browse Source 
Can be run via `gradle pmd`.

Mostly making fields final where appropriate.
This commit is contained in:
Peter Serwylo 2016-12-01 12:13:32 +11:00
parent 1f83cf1eca
commit c50c9f2ea0
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
View File

@ -752,28 +752,28 @@ public class AppDetailsRecyclerViewAdapter
} }
} }
private View.OnClickListener mOnInstallClickListener = new View.OnClickListener() { private final View.OnClickListener mOnInstallClickListener = new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
mCallbacks.installApk(); mCallbacks.installApk();
} }
}; };
private View.OnClickListener mOnUnInstallClickListener = new View.OnClickListener() { private final View.OnClickListener mOnUnInstallClickListener = new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
mCallbacks.uninstallApk(); mCallbacks.uninstallApk();
} }
}; };
private View.OnClickListener mOnUpgradeClickListener = new View.OnClickListener() { private final View.OnClickListener mOnUpgradeClickListener = new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
mCallbacks.upgradeApk(); mCallbacks.upgradeApk();
} }
}; };
private View.OnClickListener mOnLaunchClickListener = new View.OnClickListener() { private final View.OnClickListener mOnLaunchClickListener = new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
mCallbacks.launchApk(); mCallbacks.launchApk();

4
app/src/main/java/org/fdroid/fdroid/views/LinearLayoutManagerSnapHelper.java
View File

@ -21,8 +21,8 @@ public class LinearLayoutManagerSnapHelper extends LinearSnapHelper {
void onSnappedToView(View view, int position); void onSnappedToView(View view, int position);
} }
private LinearLayoutManager mLlm; private final LinearLayoutManager mLlm;
private OrientationHelper mOrientationHelper; private final OrientationHelper mOrientationHelper;
private LinearSnapHelperListener mListener; private LinearSnapHelperListener mListener;
public LinearLayoutManagerSnapHelper(LinearLayoutManager llm) { public LinearLayoutManagerSnapHelper(LinearLayoutManager llm) {

4
app/src/main/java/org/fdroid/fdroid/views/ShareChooserDialog.java
View File

@ -52,10 +52,6 @@ public class ShareChooserDialog extends BottomSheetDialogFragment {
private ShareChooserDialogListener mListener; private ShareChooserDialogListener mListener;
public ShareChooserDialog() {
super();
}
private void setListener(ShareChooserDialogListener listener) { private void setListener(ShareChooserDialogListener listener) {
mListener = listener; mListener = listener;
} }