From c50c9f2ea0fa7dd453a3dd942a58ec59a393daff Mon Sep 17 00:00:00 2001
From: Peter Serwylo <peter@serwylo.com>
Date: Thu, 1 Dec 2016 12:13:32 +1100
Subject: [PATCH] Appease pmd

Can be run via `gradle pmd`.

Mostly making fields final where appropriate.
---
 .../fdroid/views/AppDetailsRecyclerViewAdapter.java       | 8 ++++----
 .../fdroid/views/LinearLayoutManagerSnapHelper.java       | 4 ++--
 .../java/org/fdroid/fdroid/views/ShareChooserDialog.java  | 4 ----
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
index 64143d2db..4de04558e 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java
@@ -752,28 +752,28 @@ public class AppDetailsRecyclerViewAdapter
         }
     }
 
-    private View.OnClickListener mOnInstallClickListener = new View.OnClickListener() {
+    private final View.OnClickListener mOnInstallClickListener = new View.OnClickListener() {
         @Override
         public void onClick(View v) {
             mCallbacks.installApk();
         }
     };
 
-    private View.OnClickListener mOnUnInstallClickListener = new View.OnClickListener() {
+    private final View.OnClickListener mOnUnInstallClickListener = new View.OnClickListener() {
         @Override
         public void onClick(View v) {
             mCallbacks.uninstallApk();
         }
     };
 
-    private View.OnClickListener mOnUpgradeClickListener = new View.OnClickListener() {
+    private final View.OnClickListener mOnUpgradeClickListener = new View.OnClickListener() {
         @Override
         public void onClick(View v) {
             mCallbacks.upgradeApk();
         }
     };
 
-    private View.OnClickListener mOnLaunchClickListener = new View.OnClickListener() {
+    private final View.OnClickListener mOnLaunchClickListener = new View.OnClickListener() {
         @Override
         public void onClick(View v) {
             mCallbacks.launchApk();
diff --git a/app/src/main/java/org/fdroid/fdroid/views/LinearLayoutManagerSnapHelper.java b/app/src/main/java/org/fdroid/fdroid/views/LinearLayoutManagerSnapHelper.java
index 1eae3bea7..114c25e38 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/LinearLayoutManagerSnapHelper.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/LinearLayoutManagerSnapHelper.java
@@ -21,8 +21,8 @@ public class LinearLayoutManagerSnapHelper extends LinearSnapHelper {
         void onSnappedToView(View view, int position);
     }
 
-    private LinearLayoutManager mLlm;
-    private OrientationHelper mOrientationHelper;
+    private final LinearLayoutManager mLlm;
+    private final OrientationHelper mOrientationHelper;
     private LinearSnapHelperListener mListener;
 
     public LinearLayoutManagerSnapHelper(LinearLayoutManager llm) {
diff --git a/app/src/main/java/org/fdroid/fdroid/views/ShareChooserDialog.java b/app/src/main/java/org/fdroid/fdroid/views/ShareChooserDialog.java
index f5ff4225e..b38252a4b 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/ShareChooserDialog.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/ShareChooserDialog.java
@@ -52,10 +52,6 @@ public class ShareChooserDialog extends BottomSheetDialogFragment {
 
     private ShareChooserDialogListener mListener;
 
-    public ShareChooserDialog() {
-        super();
-    }
-
     private void setListener(ShareChooserDialogListener listener) {
         mListener = listener;
     }