Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify view_all_description logic

Browse Source 
* Use a positive if condition
* Invert bool in one place
This commit is contained in:
Daniel Martí 2015-09-18 18:35:27 -07:00
parent b54ae7ba25
commit a1fb4636d2
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
F-Droid/src/org/fdroid/fdroid/AppDetails.java
View File

@ -1305,15 +1305,14 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
public void onClick(View v) { public void onClick(View v) {
final TextView description = (TextView) ll_view_more_description.findViewById(R.id.description); final TextView description = (TextView) ll_view_more_description.findViewById(R.id.description);
final ImageView view_more_permissions = (ImageView) ll_view_more_description.findViewById(R.id.view_more_description); final ImageView view_more_permissions = (ImageView) ll_view_more_description.findViewById(R.id.view_more_description);
if (!view_all_description) { if (view_all_description) {
view_all_description = true;
description.setMaxLines(MAX_LINES);
view_more_permissions.setImageResource(R.drawable.ic_expand_more_grey600);
} else {
view_all_description = false;
description.setMaxLines(Integer.MAX_VALUE); description.setMaxLines(Integer.MAX_VALUE);
view_more_permissions.setImageResource(R.drawable.ic_expand_less_grey600); view_more_permissions.setImageResource(R.drawable.ic_expand_less_grey600);
} else {
description.setMaxLines(MAX_LINES);
view_more_permissions.setImageResource(R.drawable.ic_expand_more_grey600);
} }
view_all_description ^= true;
} }
}; };