From a1fb4636d2598f75f22180500dfda70800f86486 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Fri, 18 Sep 2015 18:35:27 -0700 Subject: [PATCH] Simplify view_all_description logic * Use a positive if condition * Invert bool in one place --- F-Droid/src/org/fdroid/fdroid/AppDetails.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/F-Droid/src/org/fdroid/fdroid/AppDetails.java b/F-Droid/src/org/fdroid/fdroid/AppDetails.java index a686cc562..8b36bfcfb 100644 --- a/F-Droid/src/org/fdroid/fdroid/AppDetails.java +++ b/F-Droid/src/org/fdroid/fdroid/AppDetails.java @@ -1305,15 +1305,14 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A public void onClick(View v) { final TextView description = (TextView) ll_view_more_description.findViewById(R.id.description); final ImageView view_more_permissions = (ImageView) ll_view_more_description.findViewById(R.id.view_more_description); - if (!view_all_description) { - view_all_description = true; - description.setMaxLines(MAX_LINES); - view_more_permissions.setImageResource(R.drawable.ic_expand_more_grey600); - } else { - view_all_description = false; + if (view_all_description) { description.setMaxLines(Integer.MAX_VALUE); view_more_permissions.setImageResource(R.drawable.ic_expand_less_grey600); + } else { + description.setMaxLines(MAX_LINES); + view_more_permissions.setImageResource(R.drawable.ic_expand_more_grey600); } + view_all_description ^= true; } };