Apply a few weaker access suggestions from Studio

This commit is contained in:
Daniel Martí 2016-05-07 23:04:54 +01:00
parent 0baf443b63
commit 98130de4ae
4 changed files with 8 additions and 8 deletions

View File

@ -875,7 +875,7 @@ public class AppDetails extends AppCompatActivity {
DownloaderService.queue(this, apk.packageName, activeDownloadUrlString);
}
public void removeApk(String packageName) {
private void removeApk(String packageName) {
try {
installer.deletePackage(packageName);
} catch (InstallFailedException e) {
@ -969,11 +969,11 @@ public class AppDetails extends AppCompatActivity {
}
}
public App getApp() {
private App getApp() {
return app;
}
public ApkListAdapter getApks() {
private ApkListAdapter getApks() {
return adapter;
}

View File

@ -20,7 +20,7 @@ import java.io.File;
* {@link FDroidApp#onCreate()}
*/
public class CleanCacheService extends IntentService {
public static final String TAG = "CleanCacheService";
private static final String TAG = "CleanCacheService";
/**
* Schedule or cancel this service to update the app index, according to the

View File

@ -80,9 +80,9 @@ import java.util.HashMap;
* @see android.os.AsyncTask
*/
public class DownloaderService extends Service {
public static final String TAG = "DownloaderService";
private static final String TAG = "DownloaderService";
static final String EXTRA_PACKAGE_NAME = "org.fdroid.fdroid.net.DownloaderService.extra.PACKAGE_NAME";
private static final String EXTRA_PACKAGE_NAME = "org.fdroid.fdroid.net.DownloaderService.extra.PACKAGE_NAME";
private static final String ACTION_QUEUE = "org.fdroid.fdroid.net.DownloaderService.action.QUEUE";
private static final String ACTION_CANCEL = "org.fdroid.fdroid.net.DownloaderService.action.CANCEL";

View File

@ -26,8 +26,8 @@ public class HttpDownloader extends Downloader {
protected static final String HEADER_IF_NONE_MATCH = "If-None-Match";
protected static final String HEADER_FIELD_ETAG = "ETag";
public final String username;
public final String password;
private final String username;
private final String password;
protected HttpURLConnection connection;
private int statusCode = -1;