From 98130de4ae70d46598b307dce1d541977d27b8ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sat, 7 May 2016 23:04:54 +0100
Subject: [PATCH] Apply a few weaker access suggestions from Studio

---
 app/src/main/java/org/fdroid/fdroid/AppDetails.java         | 6 +++---
 app/src/main/java/org/fdroid/fdroid/CleanCacheService.java  | 2 +-
 .../main/java/org/fdroid/fdroid/net/DownloaderService.java  | 4 ++--
 app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/AppDetails.java b/app/src/main/java/org/fdroid/fdroid/AppDetails.java
index 0615f9b94..8142f62e4 100644
--- a/app/src/main/java/org/fdroid/fdroid/AppDetails.java
+++ b/app/src/main/java/org/fdroid/fdroid/AppDetails.java
@@ -875,7 +875,7 @@ public class AppDetails extends AppCompatActivity {
         DownloaderService.queue(this, apk.packageName, activeDownloadUrlString);
     }
 
-    public void removeApk(String packageName) {
+    private void removeApk(String packageName) {
         try {
             installer.deletePackage(packageName);
         } catch (InstallFailedException e) {
@@ -969,11 +969,11 @@ public class AppDetails extends AppCompatActivity {
         }
     }
 
-    public App getApp() {
+    private App getApp() {
         return app;
     }
 
-    public ApkListAdapter getApks() {
+    private ApkListAdapter getApks() {
         return adapter;
     }
 
diff --git a/app/src/main/java/org/fdroid/fdroid/CleanCacheService.java b/app/src/main/java/org/fdroid/fdroid/CleanCacheService.java
index 0838b6770..463af770d 100644
--- a/app/src/main/java/org/fdroid/fdroid/CleanCacheService.java
+++ b/app/src/main/java/org/fdroid/fdroid/CleanCacheService.java
@@ -20,7 +20,7 @@ import java.io.File;
  * {@link FDroidApp#onCreate()}
  */
 public class CleanCacheService extends IntentService {
-    public static final String TAG = "CleanCacheService";
+    private static final String TAG = "CleanCacheService";
 
     /**
      * Schedule or cancel this service to update the app index, according to the
diff --git a/app/src/main/java/org/fdroid/fdroid/net/DownloaderService.java b/app/src/main/java/org/fdroid/fdroid/net/DownloaderService.java
index d483d36e4..b8d93c0d0 100644
--- a/app/src/main/java/org/fdroid/fdroid/net/DownloaderService.java
+++ b/app/src/main/java/org/fdroid/fdroid/net/DownloaderService.java
@@ -80,9 +80,9 @@ import java.util.HashMap;
  * @see android.os.AsyncTask
  */
 public class DownloaderService extends Service {
-    public static final String TAG = "DownloaderService";
+    private static final String TAG = "DownloaderService";
 
-    static final String EXTRA_PACKAGE_NAME = "org.fdroid.fdroid.net.DownloaderService.extra.PACKAGE_NAME";
+    private static final String EXTRA_PACKAGE_NAME = "org.fdroid.fdroid.net.DownloaderService.extra.PACKAGE_NAME";
 
     private static final String ACTION_QUEUE = "org.fdroid.fdroid.net.DownloaderService.action.QUEUE";
     private static final String ACTION_CANCEL = "org.fdroid.fdroid.net.DownloaderService.action.CANCEL";
diff --git a/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java b/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java
index f6a41c4fd..11d87a8b3 100644
--- a/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java
+++ b/app/src/main/java/org/fdroid/fdroid/net/HttpDownloader.java
@@ -26,8 +26,8 @@ public class HttpDownloader extends Downloader {
     protected static final String HEADER_IF_NONE_MATCH = "If-None-Match";
     protected static final String HEADER_FIELD_ETAG = "ETag";
 
-    public final String username;
-    public final String password;
+    private final String username;
+    private final String password;
     protected HttpURLConnection connection;
     private int statusCode = -1;