Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SwapAppsView: don't crash on update if app is null

Browse Source 
java.lang.NullPointerException: Attempt to read from field 'java.lang.String org.fdroid.fdroid.data.App.packageName' on a null object reference
at org.fdroid.fdroid.views.swap.SwapAppsView$AppListAdapter$ViewHolder$2.onChange(SwapAppsView.java:294)
at android.database.ContentObserver.onChange(ContentObserver.java:130)
at android.database.ContentObserver.onChange(ContentObserver.java:145)
at android.database.ContentObserver$NotificationRunnable.run(ContentObserver.java:216)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:152)
at android.app.ActivityThread.main(ActivityThread.java:5497)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
This commit is contained in:
Hans-Christoph Steiner 2019-03-29 00:05:00 +01:00
parent 81139c40fa
commit 934eb06ff1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/full/java/org/fdroid/fdroid/views/swap/SwapAppsView.java
View File

@ -288,9 +288,9 @@ public class SwapAppsView extends ListView implements
@Override @Override
public void onChange(boolean selfChange) { public void onChange(boolean selfChange) {
Activity activity = getActivity(); Activity activity = getActivity();
if (activity != null) { if (activity != null && app != null) {
app = AppProvider.Helper.findSpecificApp( app = AppProvider.Helper.findSpecificApp(
getActivity().getContentResolver(), activity.getContentResolver(),
app.packageName, app.packageName,
app.repoId, app.repoId,
AppMetadataTable.Cols.ALL); AppMetadataTable.Cols.ALL);