From 934eb06ff13f8d33218d88af9a2ac48d0ae1884f Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 29 Mar 2019 00:05:00 +0100 Subject: [PATCH] SwapAppsView: don't crash on update if app is null java.lang.NullPointerException: Attempt to read from field 'java.lang.String org.fdroid.fdroid.data.App.packageName' on a null object reference at org.fdroid.fdroid.views.swap.SwapAppsView$AppListAdapter$ViewHolder$2.onChange(SwapAppsView.java:294) at android.database.ContentObserver.onChange(ContentObserver.java:130) at android.database.ContentObserver.onChange(ContentObserver.java:145) at android.database.ContentObserver$NotificationRunnable.run(ContentObserver.java:216) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:152) at android.app.ActivityThread.main(ActivityThread.java:5497) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616) --- .../full/java/org/fdroid/fdroid/views/swap/SwapAppsView.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/full/java/org/fdroid/fdroid/views/swap/SwapAppsView.java b/app/src/full/java/org/fdroid/fdroid/views/swap/SwapAppsView.java index 076d4ec45..88ad58021 100644 --- a/app/src/full/java/org/fdroid/fdroid/views/swap/SwapAppsView.java +++ b/app/src/full/java/org/fdroid/fdroid/views/swap/SwapAppsView.java @@ -288,9 +288,9 @@ public class SwapAppsView extends ListView implements @Override public void onChange(boolean selfChange) { Activity activity = getActivity(); - if (activity != null) { + if (activity != null && app != null) { app = AppProvider.Helper.findSpecificApp( - getActivity().getContentResolver(), + activity.getContentResolver(), app.packageName, app.repoId, AppMetadataTable.Cols.ALL);