Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

checkstyle: Add LocalVariableName

Browse Source
This commit is contained in:
Daniel Martí 2015-10-09 10:56:50 +02:00
parent b5f62c03cb
commit 6ee3dba3ea
3 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
F-Droid/src/org/fdroid/fdroid/AppDetails.java
View File

@ -840,9 +840,9 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
if (repoaddress == null) return; if (repoaddress == null) return;
if (!apk.compatible) { if (!apk.compatible) {
AlertDialog.Builder ask_alrt = new AlertDialog.Builder(this); AlertDialog.Builder builder = new AlertDialog.Builder(this);
ask_alrt.setMessage(R.string.installIncompatible); builder.setMessage(R.string.installIncompatible);
ask_alrt.setPositiveButton(R.string.yes, builder.setPositiveButton(R.string.yes,
new DialogInterface.OnClickListener() { new DialogInterface.OnClickListener() {
@Override @Override
public void onClick(DialogInterface dialog, public void onClick(DialogInterface dialog,
@ -850,14 +850,14 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
startDownload(apk, repoaddress); startDownload(apk, repoaddress);
} }
}); });
ask_alrt.setNegativeButton(R.string.no, builder.setNegativeButton(R.string.no,
new DialogInterface.OnClickListener() { new DialogInterface.OnClickListener() {
@Override @Override
public void onClick(DialogInterface dialog, public void onClick(DialogInterface dialog,
int whichButton) { int whichButton) {
} }
}); });
AlertDialog alert = ask_alrt.create(); AlertDialog alert = builder.create();
alert.show(); alert.show();
return; return;
} }
@ -1698,9 +1698,9 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
if (getApp().installedVersionCode == apk.vercode) { if (getApp().installedVersionCode == apk.vercode) {
remove(); remove();
} else if (getApp().installedVersionCode > apk.vercode) { } else if (getApp().installedVersionCode > apk.vercode) {
AlertDialog.Builder ask_alrt = new AlertDialog.Builder(getActivity()); AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
ask_alrt.setMessage(R.string.installDowngrade); builder.setMessage(R.string.installDowngrade);
ask_alrt.setPositiveButton(R.string.yes, builder.setPositiveButton(R.string.yes,
new DialogInterface.OnClickListener() { new DialogInterface.OnClickListener() {
@Override @Override
public void onClick(DialogInterface dialog, public void onClick(DialogInterface dialog,
@ -1708,14 +1708,14 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
install(apk); install(apk);
} }
}); });
ask_alrt.setNegativeButton(R.string.no, builder.setNegativeButton(R.string.no,
new DialogInterface.OnClickListener() { new DialogInterface.OnClickListener() {
@Override @Override
public void onClick(DialogInterface dialog, public void onClick(DialogInterface dialog,
int whichButton) { int whichButton) {
} }
}); });
AlertDialog alert = ask_alrt.create(); AlertDialog alert = builder.create();
alert.show(); alert.show();
} else { } else {
install(apk); install(apk);

6
F-Droid/src/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java
View File

@ -366,11 +366,11 @@ public class AppSecurityPermissions {
} }
public int getPermissionCount(int which) { public int getPermissionCount(int which) {
int N = 0; int n = 0;
for (int i = 0; i < mPermGroupsList.size(); i++) { for (int i = 0; i < mPermGroupsList.size(); i++) {
N += getPermissionList(mPermGroupsList.get(i), which).size(); n += getPermissionList(mPermGroupsList.get(i), which).size();
} }
return N; return n;
} }
public View getPermissionsView(int which) { public View getPermissionsView(int which) {

2
config/checkstyle/checkstyle.xml
View File

@ -18,7 +18,7 @@
<!--<module name="ConstantName" />--> <!--<module name="ConstantName" />-->
<!--<module name="LocalFinalVariableName" />--> <!--<module name="LocalFinalVariableName" />-->
<!--<module name="LocalVariableName" />--> <module name="LocalVariableName" />
<module name="MemberName" /> <module name="MemberName" />
<module name="MethodName" /> <module name="MethodName" />
<module name="PackageName" /> <module name="PackageName" />