From 6ee3dba3eaa69331cb8aeb58fa869caa6741a66a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Fri, 9 Oct 2015 10:56:50 +0200
Subject: [PATCH] checkstyle: Add LocalVariableName
---
F-Droid/src/org/fdroid/fdroid/AppDetails.java | 20 +++++++++----------
.../views/AppSecurityPermissions.java | 6 +++---
config/checkstyle/checkstyle.xml | 2 +-
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/F-Droid/src/org/fdroid/fdroid/AppDetails.java b/F-Droid/src/org/fdroid/fdroid/AppDetails.java
index e3ee80138..fbc801f98 100644
--- a/F-Droid/src/org/fdroid/fdroid/AppDetails.java
+++ b/F-Droid/src/org/fdroid/fdroid/AppDetails.java
@@ -840,9 +840,9 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
if (repoaddress == null) return;
if (!apk.compatible) {
- AlertDialog.Builder ask_alrt = new AlertDialog.Builder(this);
- ask_alrt.setMessage(R.string.installIncompatible);
- ask_alrt.setPositiveButton(R.string.yes,
+ AlertDialog.Builder builder = new AlertDialog.Builder(this);
+ builder.setMessage(R.string.installIncompatible);
+ builder.setPositiveButton(R.string.yes,
new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog,
@@ -850,14 +850,14 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
startDownload(apk, repoaddress);
}
});
- ask_alrt.setNegativeButton(R.string.no,
+ builder.setNegativeButton(R.string.no,
new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog,
int whichButton) {
}
});
- AlertDialog alert = ask_alrt.create();
+ AlertDialog alert = builder.create();
alert.show();
return;
}
@@ -1698,9 +1698,9 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
if (getApp().installedVersionCode == apk.vercode) {
remove();
} else if (getApp().installedVersionCode > apk.vercode) {
- AlertDialog.Builder ask_alrt = new AlertDialog.Builder(getActivity());
- ask_alrt.setMessage(R.string.installDowngrade);
- ask_alrt.setPositiveButton(R.string.yes,
+ AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
+ builder.setMessage(R.string.installDowngrade);
+ builder.setPositiveButton(R.string.yes,
new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog,
@@ -1708,14 +1708,14 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
install(apk);
}
});
- ask_alrt.setNegativeButton(R.string.no,
+ builder.setNegativeButton(R.string.no,
new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog,
int whichButton) {
}
});
- AlertDialog alert = ask_alrt.create();
+ AlertDialog alert = builder.create();
alert.show();
} else {
install(apk);
diff --git a/F-Droid/src/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java b/F-Droid/src/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java
index da7bfe5b5..67c402dda 100644
--- a/F-Droid/src/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java
+++ b/F-Droid/src/org/fdroid/fdroid/privileged/views/AppSecurityPermissions.java
@@ -366,11 +366,11 @@ public class AppSecurityPermissions {
}
public int getPermissionCount(int which) {
- int N = 0;
+ int n = 0;
for (int i = 0; i < mPermGroupsList.size(); i++) {
- N += getPermissionList(mPermGroupsList.get(i), which).size();
+ n += getPermissionList(mPermGroupsList.get(i), which).size();
}
- return N;
+ return n;
}
public View getPermissionsView(int which) {
diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index dd4f42a53..b0dc0ad6b 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -18,7 +18,7 @@
<!--<module name="ConstantName" />-->
<!--<module name="LocalFinalVariableName" />-->
- <!--<module name="LocalVariableName" />-->
+ <module name="LocalVariableName" />
<module name="MemberName" />
<module name="MethodName" />
<module name="PackageName" />