Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

More specific paddings round the "collapsable lists" at the bottom of app details.

Browse Source 
Also tried a more specific naming scheme for dimens to make it clearer where
they are to be used. This increased the padding on the left/right of the collapsable
lists. It also decreased the padding above/below.
This commit is contained in:
Peter Serwylo 2016-12-21 22:16:09 +11:00
parent d54c138a1d
commit 6a6cede4de
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/src/main/res/layout/app_details2_links.xml
View File

@ -5,7 +5,12 @@
android:id="@+id/ll_information"
android:layout_width="fill_parent"
android:layout_height="wrap_content"
android:layout_margin="@dimen/details_activity_padding"
android:layout_marginStart="@dimen/details_activity_padding"
android:layout_marginLeft="@dimen/details_activity_padding"
android:layout_marginEnd="@dimen/details_activity_padding"
android:layout_marginRight="@dimen/details_activity_padding"
android:layout_marginTop="@dimen/details_activity__collapsable_lists__padding__vertical"
android:layout_marginBottom="@dimen/details_activity__collapsable_lists__padding__vertical"
android:clickable="true"
android:orientation="vertical"
tools:ignore="UnusedAttribute">
@ -13,6 +18,10 @@
android:id="@+id/information"
style="@style/AppDetailsSubheaderText"
android:text="@string/links"
android:paddingLeft="@dimen/details_activity__collapsable_lists__padding__horizontal"
android:paddingStart="@dimen/details_activity__collapsable_lists__padding__horizontal"
android:paddingRight="@dimen/details_activity__collapsable_lists__padding__horizontal"
android:paddingEnd="@dimen/details_activity__collapsable_lists__padding__horizontal"
android:drawableRight="@drawable/ic_expand_more_grey600"
android:drawableEnd="@drawable/ic_expand_more_grey600"
android:drawableLeft="@drawable/ic_website"

7
app/src/main/res/values/dimens.xml
View File

@ -4,7 +4,12 @@
<dimen name="layout_horizontal_margin">16dp</dimen>
<dimen name="material_listitem_height">48dp</dimen>
<dimen name="app_bar_height">180dp</dimen>
<dimen name="details_activity_padding">8dp</dimen>
<dimen name="details_activity_padding">16dp</dimen>
<dimen name="details_activity__collapsable_lists__padding__vertical">3dp</dimen>
<!-- This is in addition to the padding that almost all items in the app details screen have
applied. The collapsable lists have a little extra on the sides. -->
<dimen name="details_activity__collapsable_lists__padding__horizontal">4dp</dimen>
<dimen name="details_screenshot_height">200dp</dimen>
<dimen name="details_screenshot_width">200dp</dimen>