From 6a6cede4dea0a564a95a563e0ab46123694d1053 Mon Sep 17 00:00:00 2001
From: Peter Serwylo <peter@serwylo.com>
Date: Wed, 21 Dec 2016 22:16:09 +1100
Subject: [PATCH] More specific paddings round the "collapsable lists" at the
 bottom of app details.

Also tried a more specific naming scheme for dimens to make it clearer where
they are to be used. This increased the padding on the left/right of the collapsable
lists. It also decreased the padding above/below.
---
 app/src/main/res/layout/app_details2_links.xml | 11 ++++++++++-
 app/src/main/res/values/dimens.xml             |  7 ++++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/app/src/main/res/layout/app_details2_links.xml b/app/src/main/res/layout/app_details2_links.xml
index 830cb42ab..0ff67bbc1 100644
--- a/app/src/main/res/layout/app_details2_links.xml
+++ b/app/src/main/res/layout/app_details2_links.xml
@@ -5,7 +5,12 @@
     android:id="@+id/ll_information"
     android:layout_width="fill_parent"
     android:layout_height="wrap_content"
-    android:layout_margin="@dimen/details_activity_padding"
+    android:layout_marginStart="@dimen/details_activity_padding"
+    android:layout_marginLeft="@dimen/details_activity_padding"
+    android:layout_marginEnd="@dimen/details_activity_padding"
+    android:layout_marginRight="@dimen/details_activity_padding"
+    android:layout_marginTop="@dimen/details_activity__collapsable_lists__padding__vertical"
+    android:layout_marginBottom="@dimen/details_activity__collapsable_lists__padding__vertical"
     android:clickable="true"
     android:orientation="vertical"
     tools:ignore="UnusedAttribute">
@@ -13,6 +18,10 @@
         android:id="@+id/information"
         style="@style/AppDetailsSubheaderText"
         android:text="@string/links"
+        android:paddingLeft="@dimen/details_activity__collapsable_lists__padding__horizontal"
+        android:paddingStart="@dimen/details_activity__collapsable_lists__padding__horizontal"
+        android:paddingRight="@dimen/details_activity__collapsable_lists__padding__horizontal"
+        android:paddingEnd="@dimen/details_activity__collapsable_lists__padding__horizontal"
         android:drawableRight="@drawable/ic_expand_more_grey600"
         android:drawableEnd="@drawable/ic_expand_more_grey600"
         android:drawableLeft="@drawable/ic_website"
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index c85219705..20d2d578d 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -4,7 +4,12 @@
     <dimen name="layout_horizontal_margin">16dp</dimen>
     <dimen name="material_listitem_height">48dp</dimen>
     <dimen name="app_bar_height">180dp</dimen>
-    <dimen name="details_activity_padding">8dp</dimen>
+    <dimen name="details_activity_padding">16dp</dimen>
+
+    <dimen name="details_activity__collapsable_lists__padding__vertical">3dp</dimen>
+    <!-- This is in addition to the padding that almost all items in the app details screen have
+         applied. The collapsable lists have a little extra on the sides. -->
+    <dimen name="details_activity__collapsable_lists__padding__horizontal">4dp</dimen>
 
     <dimen name="details_screenshot_height">200dp</dimen>
     <dimen name="details_screenshot_width">200dp</dimen>