Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove redundant calls to String.format()

Browse Source 
getString() can do formats itself.
This commit is contained in:
Hans-Christoph Steiner 2018-06-15 13:22:19 +02:00
parent a8af84ecbc
commit 0d5d071eac
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java
View File

@ -501,7 +501,7 @@ public class ManageReposActivity extends AppCompatActivity
} }
if (messageRes > 0) { if (messageRes > 0) {
overwriteMessage.setText(String.format(getString(messageRes), name)); overwriteMessage.setText(getString(messageRes, name));
overwriteMessage.setVisibility(View.VISIBLE); overwriteMessage.setVisibility(View.VISIBLE);
if (redMessage) { if (redMessage) {
overwriteMessage.setTextColor(getResources().getColor(R.color.red)); overwriteMessage.setTextColor(getResources().getColor(R.color.red));
@ -839,7 +839,7 @@ public class ManageReposActivity extends AppCompatActivity
bssid = bssid.toLowerCase(Locale.ENGLISH); bssid = bssid.toLowerCase(Locale.ENGLISH);
String newRepoBssid = Uri.decode(newRepo.getBssid()).toLowerCase(Locale.ENGLISH); String newRepoBssid = Uri.decode(newRepo.getBssid()).toLowerCase(Locale.ENGLISH);
if (!bssid.equals(newRepoBssid)) { if (!bssid.equals(newRepoBssid)) {
String msg = String.format(getString(R.string.not_on_same_wifi), newRepo.getSsid()); String msg = getString(R.string.not_on_same_wifi, newRepo.getSsid());
Toast.makeText(this, msg, Toast.LENGTH_LONG).show(); Toast.makeText(this, msg, Toast.LENGTH_LONG).show();
} }
// TODO we should help the user to the right thing here, // TODO we should help the user to the right thing here,