From 0d5d071eac06b16371af6612b22afb1ede737634 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 15 Jun 2018 13:22:19 +0200 Subject: [PATCH] remove redundant calls to String.format() getString() can do formats itself. --- .../java/org/fdroid/fdroid/views/ManageReposActivity.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java b/app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java index 5ff7e3556..fe579d57d 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java +++ b/app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java @@ -501,7 +501,7 @@ public class ManageReposActivity extends AppCompatActivity } if (messageRes > 0) { - overwriteMessage.setText(String.format(getString(messageRes), name)); + overwriteMessage.setText(getString(messageRes, name)); overwriteMessage.setVisibility(View.VISIBLE); if (redMessage) { overwriteMessage.setTextColor(getResources().getColor(R.color.red)); @@ -839,7 +839,7 @@ public class ManageReposActivity extends AppCompatActivity bssid = bssid.toLowerCase(Locale.ENGLISH); String newRepoBssid = Uri.decode(newRepo.getBssid()).toLowerCase(Locale.ENGLISH); if (!bssid.equals(newRepoBssid)) { - String msg = String.format(getString(R.string.not_on_same_wifi), newRepo.getSsid()); + String msg = getString(R.string.not_on_same_wifi, newRepo.getSsid()); Toast.makeText(this, msg, Toast.LENGTH_LONG).show(); } // TODO we should help the user to the right thing here,