From cf05a85ad6639a0420ef271c387f765d3f621463 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Thu, 3 Aug 2023 08:50:45 -0700 Subject: [PATCH] Handle urbackup clients with images disabled --- src/widgets/urbackup/component.jsx | 4 ++-- src/widgets/urbackup/proxy.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/widgets/urbackup/component.jsx b/src/widgets/urbackup/component.jsx index 9b03b595..2e3b5166 100644 --- a/src/widgets/urbackup/component.jsx +++ b/src/widgets/urbackup/component.jsx @@ -14,7 +14,7 @@ function hasRecentBackups(client, maxDays){ const days = maxDays || 3; const diffTime = days*24*60*60 // 7 days const recentFile = (client.lastbackup > (Date.now() / 1000 - diffTime)); - const recentImage = ((client.lastbackup_image > (Date.now() / 1000 - diffTime)||client.image_not_supported)); + const recentImage = client.image_not_supported || client.image_disabled || (client.lastbackup_image > (Date.now() / 1000 - diffTime)); return (recentFile && recentImage); } @@ -26,7 +26,7 @@ function determineStatuses(urbackupData) { urbackupData.clientStatuses.forEach((client) => { status = Status.noRecent; if (hasRecentBackups(client, urbackupData.maxDays)) { - status = (client.file_ok && (client.image_ok || client.image_not_supported)) ? Status.ok : Status.errored; + status = (client.file_ok && (client.image_ok || client.image_not_supported || client.image_disabled)) ? Status.ok : Status.errored; } switch (status) { case Status.ok: diff --git a/src/widgets/urbackup/proxy.js b/src/widgets/urbackup/proxy.js index 3075afd0..b0e4a38b 100644 --- a/src/widgets/urbackup/proxy.js +++ b/src/widgets/urbackup/proxy.js @@ -25,7 +25,7 @@ await (async () => { maxDays: serviceWidget.maxDays }); } catch (error) { - res.status(500).json({ error: "Something Broke" }) + res.status(500).json({ error: "Error communicating with UrBackup server" }) } })();