b66810944f
There was a race condition such that when the cancel `Intent` is received, it would queue up a message on the download thread to stop downloading. This was followed by cancelling the notification on the thread the `Intent` was received on. As a result of the message taking some time to get to the other thread, it would likely cause another progress notification to be shown after we had already removed that notification - making it show again after being cancelled. The code in the download thread progress handler, which updates the notification with progress, is not perfect. It does a check before deciding to broadcast progress and update the notification. However, the check happens at the beginning of the group of expressions. As such, there is likely a small change that `isActive` returns true, then the notification is cancelled on the other thread, and finally, the download thread updates the progress again. However this is better than it was before where the notification didn't go away. Previously, apks were not being removed from the queue once download was completed, only when removed. It didn't cause any specific issues here, but I removed downloads from the queue after completion to prevent potential problems in the future. Now the queue is a better representation of what is to be downloaded.
F-Droid Client
Client for F-Droid, the Free Software repository system for Android.
Building with Gradle
./gradlew assembleRelease
Direct download
You can download the application directly from our site or browse it in the repo.
Contributing
See our Contributing doc for information on how to report issues, translate the app into your language or help with development.
IRC
We are on #fdroid and #fdroid-dev on Freenode. We hold weekly dev meetings
on #fdroid-dev on Tuesdays at 20h UTC, which usually last half an hour.
FAQ
- Why does F-Droid require "Unknown Sources" to install apps by default?
Because a regular Android app cannot act as a package manager on its own. To do so, it would require system privileges (see below), similar to what Google Play does.
- Can I avoid enabling "Unknown Sources" by installing F-Droid as a privileged system app?
This used to be the case, but no longer is. Now the Privileged Extension is the one that should be placed in the system. It can be bundled with a ROM or installed via a zip, or alternatively F-Droid can install it as a system app using root.
License
This program is Free Software: You can use, study share and improve it at your will. Specifically you can redistribute and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
Some icons are made by Picol, Icomoon or Dave Gandy from Flaticon or by Google and are licensed by Creative Commons BY 3.0.
Other icons are from the Material Design Icon set released under an Attribution 4.0 International license.