44b703a7d2
There is already a method for reproducibly generating an int based on a the contents of a String, thanks to @pserwylo for finding it! So urlString.hashCode() is used as the ID for Notifications and the DownloaderService queue (msg.what). This entirely replaces the QUEUE_WHATS hack. Both requestCode and msg.what just need to be unique int, and that value can always be generated by the urlString. This also fixes a bug preventing removing correct URL from Downloader queue. b66810944fec802aa119c0e5ec8b7875930a2c22 made a change that breaks removing the correct item from the queue. The `what` value must be fetched based on urlString and fed to serviceHandler.removeMessages(what). The commit made it use the `what` value from the last item that was queued. Those will often be different things. This also removes all stopForeground(true) calls except for the one in onDestroy(). The nature of an IntentService, which DownloaderService is basically a copy of, is to quit running once it is no longer processing Intents. That is also the time to remove the notification.
F-Droid Client
Client for F-Droid, the Free Software repository system for Android.
Building with Gradle
./gradlew assembleRelease
Direct download
You can download the application directly from our site or browse it in the repo.
Contributing
See our Contributing doc for information on how to report issues, translate the app into your language or help with development.
IRC
We are on #fdroid and #fdroid-dev on Freenode. We hold weekly dev meetings
on #fdroid-dev on Tuesdays at 20h UTC, which usually last half an hour.
FAQ
- Why does F-Droid require "Unknown Sources" to install apps by default?
Because a regular Android app cannot act as a package manager on its own. To do so, it would require system privileges (see below), similar to what Google Play does.
- Can I avoid enabling "Unknown Sources" by installing F-Droid as a privileged system app?
This used to be the case, but no longer is. Now the Privileged Extension is the one that should be placed in the system. It can be bundled with a ROM or installed via a zip, or alternatively F-Droid can install it as a system app using root.
License
This program is Free Software: You can use, study share and improve it at your will. Specifically you can redistribute and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
Some icons are made by Picol, Icomoon or Dave Gandy from Flaticon or by Google and are licensed by Creative Commons BY 3.0.
Other icons are from the Material Design Icon set released under an Attribution 4.0 International license.