2d377453d9
While investigating #1086 which was about swap being busted, I discovered that we recently introduced a worse bug when working with multi sig stuff. The swap process, when installing an app (or even when listening for if a user started installing - before they even did anything), would ask for an apk from any repo. This is wrong, because we should only ask for the apks from the swap repo when presented with a swap dialog. By fixing this so that it asks for a specific apk, this may also fix the issue in #1086, because that was about us not asking for enough info from the database for each Apk which was returned. Now we just return all columns, because the performance overhead should be minimal, but it prevents this class of bugs, where we didn't fully populate our value object. However, I'm not confident that it is fixed, because I was unable to reproduce it due to the other crash fixed in this change. Relevant crash: ``` java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.fdroid.fdroid.data.Apk.getUrl()' on a null object reference at org.fdroid.fdroid.views.swap.SwapAppsView$AppListAdapter$ViewHolder.setApp(SwapAppsView.java:311) at org.fdroid.fdroid.views.swap.SwapAppsView$AppListAdapter.bindView(SwapAppsView.java:422) at org.fdroid.fdroid.views.swap.SwapAppsView$AppListAdapter.newView(SwapAppsView.java:414) at android.support.v4.widget.CursorAdapter.getView(CursorAdapter.java:269) at android.widget.AbsListView.obtainView(AbsListView.java:2349) at android.widget.ListView.makeAndAddView(ListView.java:1864) at android.widget.ListView.fillDown(ListView.java:698) ... ```
F-Droid Client
Client for F-Droid, the Free Software repository system for Android.
Building with Gradle
./gradlew assembleRelease
Direct download
You can download the application directly from our site or browse it in the repo.
Contributing
See our Contributing doc for information on how to report issues, translate the app into your language or help with development.
IRC
We are on #fdroid and #fdroid-dev on Freenode. We hold weekly dev meetings
on #fdroid-dev on Thursdays at 11:30h UTC, which usually last half an hour.
FAQ
- Why does F-Droid require "Unknown Sources" to install apps by default?
Because a regular Android app cannot act as a package manager on its own. To do so, it would require system privileges (see below), similar to what Google Play does.
- Can I avoid enabling "Unknown Sources" by installing F-Droid as a privileged system app?
This used to be the case, but no longer is. Now the Privileged Extension is the one that should be placed in the system. It can be bundled with a ROM or installed via a zip, or alternatively F-Droid can install it as a system app using root.
License
This program is Free Software: You can use, study share and improve it at your will. Specifically you can redistribute and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
Some icons are made by Picol, Icomoon or Dave Gandy from Flaticon or by Google and are licensed by Creative Commons BY 3.0.
Other icons are from the Material Design Icon set released under an Attribution 4.0 International license.