Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,312 Commits 2 Branches 249 Tags
Commit Graph

5312 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Hans-Christoph Steiner
215db81802 use warning suggestions for .addAll() method and null guard 2018-03-07 22:51:39 +01:00
Hans-Christoph Steiner
5547f12527 actually fix crashes from update notifications on < android-11 
8600ce8d8a56398a4eb731f0cccb848c4e18d2eb didn't get all the affected places.

#1306
 2018-03-07 22:51:39 +01:00
Hans-Christoph Steiner
978f4a2928 ignore potential filesystem corruption 
As nice as it would be to help the users, F-Droid is not well positioned to
help the user with this problem.  The Android OS itself should do it. Plus
this issue has been open a long time, without much work on it, and the
existing solution is causing crashes.

#855
!440
!581

Utils.getBinaryHash() is used in a lot of places in the code, so its not
easy to handle this specific issue.  Here's one example:

org.fdroid.fdroid.Utils$PotentialFilesystemCorruptionException: java.io.IOException: read failed: EIO (I/O error)
	at org.fdroid.fdroid.Utils.getBinaryHash(Utils.java:426)
	at org.fdroid.fdroid.AppUpdateStatusService.findApkMatchingHash(AppUpdateStatusService.java:159)
	at org.fdroid.fdroid.AppUpdateStatusService.processDownloadedApk(AppUpdateStatusService.java:110)
	at org.fdroid.fdroid.AppUpdateStatusService.onHandleIntent(AppUpdateStatusService.java:65)
	at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.os.HandlerThread.run(HandlerThread.java:60)
 2018-03-07 22:51:39 +01:00
Hans-Christoph Steiner
b9144cc95d fix pedantic warnings in Provisioner.java to make null warnings clear 
The NullPointerException fixed by the previous commit had a warning to that
effect.  This fixes almost all the warnings to make the warnings clearer:

* unused method
* unused result of File.delete()
* can have reduced visibility
* single char static "" strings can be '' chars
 2018-03-07 22:51:39 +01:00
dkanada
64863bb1e1 add new screenshots for knownvuln replacement 2018-03-07 12:02:22 -07:00
dkanada
b4620bd0b6 fix right padding on version list 2018-03-07 12:02:22 -07:00
dkanada
8df7781eed remove image with an odd black border from the app metadata 2018-03-07 12:02:22 -07:00
dkanada
74bf125ccb modify layouts for donation buttons 2018-03-07 12:02:22 -07:00
dkanada
cf7b786054 wrap donate linear layout in a card view 2018-03-07 12:02:22 -07:00
dkanada
80915589ee improve UI for screenshots with dark theme 2018-03-07 12:02:22 -07:00
Hans-Christoph Steiner
dffac4e797 fix boot crash when Provisioner can't find ExternalFilesDir 
closes #1332
!630
 2018-03-07 16:46:18 +01:00
Hans-Christoph Steiner
6055874d9d do not crash if file vanishes during getBinaryHash() 
APKs can be deleted at any time, either by being uninstalled or deleted
from the cache.
 2018-03-07 16:46:17 +01:00
Hans-Christoph Steiner
86cc977746 Merge branch 'weblate' into 'master' 
Weblate

See merge request fdroid/fdroidclient!650
 2018-03-06 23:20:12 +00:00
Hans-Christoph Steiner
a0624639fc Weblate 2018-03-06 23:20:12 +00:00
Hans-Christoph Steiner
6bb8d5e92b a couple languages don't use "other" in plurals: be pl ru 2018-03-06 23:44:30 +01:00
Hans-Christoph Steiner
70370f5d88 LocalizationTest: hiding_dialog_message has new pattern: sds 2018-03-06 23:39:47 +01:00
Hans-Christoph Steiner
c76f7addd1 LocalizationTest: increase quantity test to 567 to test the whole range 2018-03-06 23:39:47 +01:00
Hans-Christoph Steiner
6ad3604a0e Merge branch 'afWarningQrCodeScan' into 'master' 
* jif-afWarningQrCodeScan:
  do not include english string in translations
  Correct check style errors
  Add style for the poor QR code scanning autofocus capability warning
  Add 'poor QR code scanning capability' translations
  Call to the camera autofocus checker in the view
  Add camera characteristics checker

fdroid/fdroidclient!649
closes #260
 2018-03-06 16:35:28 +01:00
Hans-Christoph Steiner
1ef1128cf7 do not include english string in translations 2018-03-06 15:15:43 +01:00
Hans-Christoph Steiner
7d45781611 Merge branch 'fix-download' into 'master' 
fix download progress for large apps

Closes #1192

See merge request fdroid/fdroidclient!647
 2018-03-06 14:04:54 +00:00
jif
3bf167e85f Correct check style errors 2018-03-01 20:52:13 +01:00
jif
6b484f4f01 Add style for the poor QR code scanning autofocus capability warning 2018-03-01 18:47:14 +01:00
jif
80b5addf62 Add 'poor QR code scanning capability' translations 2018-03-01 18:44:57 +01:00
jif
6d1fc68ff1 Call to the camera autofocus checker in the view 2018-03-01 18:40:30 +01:00
jif
b419b78c94 Add camera characteristics checker 
Those classes consist of 1 abstract class, which provide a factory for
2 classes each of which implements different behaviors according to
the Android API version.
 2018-03-01 18:35:45 +01:00
dkanada
1facc7d07c rename version layout 2018-02-27 22:40:19 -07:00
dkanada
216695285a fix int overflow 2018-02-27 22:38:54 -07:00
Hans-Christoph Steiner
d80f589b01 create_ota.sh: add second arg to allow specifying versionCode 
This is needed for a manageable build process in fdroiddata.
 2018-02-23 22:55:43 +01:00
Hans-Christoph Steiner
2d9cbc5455 untabify create_ota.sh, mixed tabs/spaces is no fun 2018-02-23 22:55:43 +01:00
Hans-Christoph Steiner
1cd2e62505 Merge branch '1300-alert-dialog-background' into 'master' 
Fix background of AlertDialogs for DialogPreferences

Closes #1300

See merge request fdroid/fdroidclient!634
 2018-02-23 14:38:13 +00:00
Hans-Christoph Steiner
31b6bbcd3e Merge branch 'data-ota' into 'master' 
Create an ota zip for installing data to f-droid

See merge request fdroid/fdroidclient!640
 2018-02-23 14:37:12 +00:00
Chirayu Desai
bee7de476b Data ota 
Based on privileged-extension 0.2.7 scripts
 2018-02-22 02:45:40 +05:30
Hans-Christoph Steiner
32601baf5c Merge branch 'liberapay' into 'master' 
add liberapay field and donation option

See merge request fdroid/fdroidclient!644
 2018-02-19 22:14:52 +00:00
Marcus Hoffmann
10e2bf2a7c
add liberapay field and donation option 
This add the liberapayID index field to the local db and then displays a
donation badge for apps that provide this.
db-version/77 		2018-02-15 19:58:12 +01:00
Hans-Christoph Steiner
f1d28d5768 versionCode 1001003 1.1-alpha3 2018-02-13 22:05:56 +01:00
Hans-Christoph Steiner
7436274685 update CHANGELOG 2018-02-13 22:05:49 +01:00
Hans-Christoph Steiner
4766ed2868 Merge branch '1.1-crash-fixes' into 'master' 
1.1 crash fixes

Closes #1325, #1305, and #1306

See merge request fdroid/fdroidclient!643
 2018-02-13 20:48:32 +00:00
Hans-Christoph Steiner
5c2e9305a8 only force index update when the locale actually changes 
This was forcing an index update on any config change, even just a simple
screen rotation.  Now it actually checks whether its needed.

closes #1325
 2018-02-13 21:26:49 +01:00
Hans-Christoph Steiner
30b00156db javadoc cleanup 2018-02-13 21:26:49 +01:00
Hans-Christoph Steiner
833d3f40fd CleanCacheService: reduce logcat noise, check if file exists before rm 2018-02-13 21:26:49 +01:00
Hans-Christoph Steiner
8a0abdd841 AppDetails2 run style formatter and fix line length issues 2018-02-13 20:34:02 +01:00
Hans-Christoph Steiner
532d1dfc72 make sure cached file exists before trying to scan it 
Files in the cache can be deleted at any time, without warning.  F-Droid's
CleanCacheService can do it, the user can do it in Settings --> Apps, etc.
So when working with files from the cache, the methods need to be extra
defensive, checking that the file that they were given still exists.

closes #1305
 2018-02-13 20:34:02 +01:00
Hans-Christoph Steiner
8600ce8d8a prevent crashes from update notifications on < android-11 
closes #1306

* https://stackoverflow.com/questions/3112008/android-java-lang-illegalargumentexception-contentintent-required-error-cause
* https://stackoverflow.com/questions/20032249/is-setcontentintentpendingintent-required-in-notificationcompat-builder
 2018-02-13 20:34:02 +01:00
Hans-Christoph Steiner
96fb01ca52 Merge branch 'error-prone' into 'master' 
Configure error prone

fdroidclient!635
 2018-02-13 20:30:23 +01:00
Hans-Christoph Steiner
a4d35244bc errorprone: All Disabled Checks As Warnings 2018-02-13 20:20:02 +01:00
Hans-Christoph Steiner
3c341b7e4b move errorprone config to its own gitlab CI job 2018-02-13 20:19:45 +01:00
Hans-Christoph Steiner
f32b26d5c3 Merge branch 'add-sorting-redo' into 'master' 
Add sorting redo

fdroidclient!637
 2018-02-13 17:28:54 +01:00
Hans-Christoph Steiner
782cf9917f FDroidApp.isAppThemeLight() to avoid opaque, super long test lines 2018-02-13 17:22:00 +01:00
Hans-Christoph Steiner
c031939379 run Android Studio code formatter e.g. Ctrl-Alt-L 2018-02-13 17:15:29 +01:00
Hans-Christoph Steiner
0982e8dd2d Merge branch 'more-fields-for-acra' into 'master' 
ACRA: add more fields to crash reports, but no user identifying info

See merge request fdroid/fdroidclient!641
 2018-02-13 16:12:16 +00:00