6075 Commits

Author SHA1 Message Date
Hans-Christoph Steiner
727e9ed5dd Merge branch 'canonical-url-overhaul' into 'master'
Canonical URL overhaul

Closes #1742, #1736, and #1727

See merge request fdroid/fdroidclient!809
2019-03-28 11:32:46 +00:00
Hans-Christoph Steiner
c7c16131e9 fix OBB support for repositories
The repoId was hard-coded to 0.

fdroid/fdroidclient#1403
2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
5f14628524 DownloaderService: improve debug logs for Canonical vs Download URLs 2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
edb2b838eb DownloaderService: track active using the canonical URL
This was using the actual download URL, which might change, depending on
whether a mirror was used.

closes #1727
2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
0aab6bc422 standardize on EXTRA_CANONICAL_URL throughout the code base
There were a few different constants used, this unifies them all into one,
so that it is easy to track where it is used, and what it means.
2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
3378c0a333 rename Canonical vs. Download URL in InstallManagerService process
AppUpdateStatusManager and InstallManagerService should be using only the
Canonical URL of the package since that is the global unique ID.  The actual
URL used to download it needs to be isolated in DownloaderService, which can
entirely manage the mirror selection process.  This is just a bunch of
renaming to make this all clearer.
2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
3a5f96e0b3 DownloaderService: use canonical URL to fix progress updates
The download URL is not the unique ID, the canonical URL is.

closes #1736
2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
7f22c3c221 DownloaderService: convert String to Uri to avoid repeated parsing
This parses the String into a Uri once per Intent, rather than once per
broadcast.  The Uri instance is also nicer to work with, since it is the
native URL format for Intents.

It should make the progress updates a bit more efficient also.
fdroid/fdroidclient#1742
2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
288577407d move towards only using canonical URLs in InstallManagerService
Only DownloaderService really needs to know about the mirror tricks, the
rest of the process should only ever use the canonical URL to keep things
simple.
2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
04298f8886 DownloaderService: only broadcast progress when it actually changes
On a slow download, this could send like 100+ updates even though no more
data had been received.

closes #1742
2019-03-28 11:41:10 +01:00
Hans-Christoph Steiner
d794c5a77c purge urlString from ProgressListener, it is unused and confusing 2019-03-28 11:41:03 +01:00
Hans-Christoph Steiner
6b0a784a26 normalize canonical URL variable names 2019-03-26 21:46:38 +01:00
Hans-Christoph Steiner
e346d2351b rename AppUpdateStatus.getUniqueKey to getCanonicalUrl
This highlights the relationship between the various things that are using
the canonical URL as the unique ID.
2019-03-26 21:46:38 +01:00
Hans-Christoph Steiner
4ea775be00 remove wrong "ERROR" description from Downloader Intend Extras
Looks like a copy-paste bug in a160476a14c40412728f4974f53d1a18f7064346
2019-03-26 21:46:38 +01:00
Hans-Christoph Steiner
a0b318c383 rename Apk.getUrl() to getCanonicalUrl() to highlight it is also an ID
This method returns the URL that points to the canonical download
source for this package.  This is also used as the unique ID for
tracking downloading, progress, and notifications throughout the
whole install process.  It is guaranteed to uniquely represent
this file since it points to a file on the file system of the
canonical webserver.
2019-03-26 21:46:38 +01:00
Hans-Christoph Steiner
19a0428944 Merge branch 'download-updates-by-default' into 'master'
Download updates by default

See merge request fdroid/fdroidclient!806
2019-03-26 20:41:25 +00:00
Hans-Christoph Steiner
80bab5611b Merge branch 'no-featured-app' into 'master'
* no-featured-app:
  cleanup imports
  fix padding of top item in Latest Tab
  Remove feature graphic of first app from "Latest" view

See merge request fdroid/fdroidclient!807
2019-03-26 21:29:33 +01:00
Hans-Christoph Steiner
51431d59ee cleanup imports 2019-03-26 21:29:13 +01:00
Hans-Christoph Steiner
496a3a2938 fix padding of top item in Latest Tab 2019-03-26 21:28:20 +01:00
mueller-ma
59fe365ed6 Remove feature graphic of first app from "Latest" view
Closes #1748
2019-03-26 18:08:38 +01:00
Hans-Christoph Steiner
e3cfe3690d set "Automatically download updates" to default true
But keep "Automatically install updates" default false for devices with
Privileged Extension.
2019-03-26 16:19:07 +01:00
Hans-Christoph Steiner
99591c050c Merge branch 'latest-apps-criteria' into 'master'
Latest apps criteria

See merge request fdroid/fdroidclient!805
2019-03-26 15:17:09 +00:00
Hans-Christoph Steiner
90d4821e99 fix checkstyle LineLength 2019-03-22 22:16:08 +01:00
Hans-Christoph Steiner
4f1855c8a1 App Details: show the app's Translation links
fdroid/fdroidserver!450

icon is:
https://material.io/tools/icons/?search=trans&icon=translate&style=baseline
db-version/82
2019-03-22 22:16:08 +01:00
Hans-Christoph Steiner
3862f941e6 add new criteria for apps shown in Latest tab
This adds requirements before an app is shown on the Latest tab.  It must
have all of these:

* name
* summary
* description
* license
* What's New entry
* at least some text localized

And then it must have at least one of these:

* screenshots
* feature graphic
2019-03-22 22:16:08 +01:00
Hans-Christoph Steiner
dcb1c3accd add flag to track localized apps for selecting in Latest tab db-version/81 2019-03-22 22:16:08 +01:00
Hans-Christoph Steiner
765bd2892d Merge branch 'nearby-view' into 'master'
Improve nearby swap splash layout

See merge request fdroid/fdroidclient!800
2019-03-22 08:46:39 +00:00
Hans-Christoph Steiner
ff111bd6af Merge branch 'improve-error' into 'master'
Mention F-Droid in index file fetch error string

See merge request fdroid/fdroidclient!803
2019-03-21 21:59:28 +00:00
AJ Jordan
8eea0f6c34
Mention F-Droid in index file fetch error string
The problem here is that oftentimes, the index fetch will happen
automatically in the background while the user is in a different app. If
the fetch fails, the warning text changed here is displayed as a toast,
but without this change there's no way to tell that it's coming from
F-Droid.
2019-03-21 13:18:08 -04:00
Hans-Christoph Steiner
5d21f0bc86 Merge branch 'weblate' into 'master'
Weblate

See merge request fdroid/fdroidclient!802
2019-03-21 13:07:15 +00:00
Hans-Christoph Steiner
bba0d5b753 Translated using Weblate: Danish (da) by Jesper Hertel <jesper.hertel@gmail.com>
Currently translated at 93.7% (401 of 428 strings)

Translation: F-Droid/F-Droid
Translate-URL: https://hosted.weblate.org/projects/f-droid/f-droid/da/
2019-03-21 13:07:15 +00:00
Hans-Christoph Steiner
42f73fb54b remove app:textAllCaps that was missed in 3adfb65c690c37855f1f120006606478575a564b
fdroid/fdroidclient!797
2019-03-21 13:28:25 +01:00
Hans-Christoph Steiner
49c32a4392 remove unused resource since 3adfb65c690c37855f1f120006606478575a564b
fdroid/fdroidclient!797
2019-03-21 13:28:24 +01:00
Hans-Christoph Steiner
07131e981b gitlab-ci: purge only: merge_requests, it doesn't work for this
The merge_requests feature is really confusing, and doesn't seem to do
anything useful for what we need it to.  Like it doesn't let new
contributors' merge requests run on the fdroid runners.
2019-03-21 13:28:24 +01:00
Hans-Christoph Steiner
5e1d95c361 add comments to translators in source strings 2019-03-21 11:56:21 +01:00
mueller-ma
05bbe94b47 Improve nearby swap splash layout
* Rename ids to something meaningful
* Remove inner layouts from constraint layout
* Use same text and button styles
* Make sure the background image doesn't overlap with the text
2019-03-17 00:04:40 +01:00
Hans-Christoph Steiner
dc59d48be3 Merge branch 'fix_button_background' into 'master'
Improve Buttons

See merge request fdroid/fdroidclient!797
2019-02-26 16:02:30 +00:00
Conny Duck
3adfb65c69 Improve Buttons 2019-02-26 16:02:30 +00:00
Sveinn í Felli
eacce08a13 Translated using Weblate: Icelandic (is) by Sveinn í Felli <sv1@fellsnet.is>
Currently translated at 78.9% (15 of 19 strings)

Translation: F-Droid/F-Droid metadata
Translate-URL: https://hosted.weblate.org/projects/f-droid/f-droid-metadata/is/

[skip ci]
2019-02-21 00:32:10 +01:00
Sveinn í Felli
7ed7cf3bcb Translated using Weblate: Icelandic (is) by Sveinn í Felli <sv1@fellsnet.is>
Currently translated at 100.0% (19 of 19 strings)

Translation: F-Droid/F-Droid metadata
Translate-URL: https://hosted.weblate.org/projects/f-droid/f-droid-metadata/is/

[skip ci]
2019-02-21 00:30:27 +01:00
Hans-Christoph Steiner
886cd0b1bf version code 1006001 1.6-alpha1 2019-02-21 00:21:55 +01:00
Hans-Christoph Steiner
3a992c10d2 update CHANGELOG 2019-02-21 00:21:55 +01:00
Hans-Christoph Steiner
72d33ffe3d remove empty changelog translations 2019-02-21 00:21:55 +01:00
Hosted Weblate
bd93c5743f clean up whitespace and formatting in strings.xml 2019-02-21 00:21:55 +01:00
Hans-Christoph Steiner
8da7fc5103 set comments to point out button labels to translators
closes #1678
2019-02-21 00:21:55 +01:00
Hans-Christoph Steiner
7ce7b46ed2 metadata: script to delete 0 size files and standardize whitespace 2019-02-21 00:21:55 +01:00
Hans-Christoph Steiner
9897c97ef8 Merge branch 'switches-to-disable-mirrors' into 'master'
add switches to disable mirrors

Closes #1696

See merge request fdroid/fdroidclient!795
2019-02-20 23:21:27 +00:00
Hans-Christoph Steiner
6a18ba1b85 RepoDetails: hide mirror lists if they are not useful
e.g., empty lists or the official mirror list just repeating the canonical
URL.
2019-02-21 00:18:25 +01:00
Hans-Christoph Steiner
b1569795a2 IndexV1Updater: use LinkedHashSet to preserve mirror ordering 2019-02-21 00:18:25 +01:00
Hans-Christoph Steiner
c3ec29df93 RepoDetails: add switches to disable any or all mirrors
This also needs to handle mirror lists with 1 element, since mirrors can
now be disabled. If the user disables all mirrors, then there will be only one URL in the
list of mirrors.  Asking for a random mirror in that case should not return
null, but the one enabled mirror.


closes #1696
db-version/80
2019-02-20 21:10:34 +01:00