14 Commits

Author SHA1 Message Date
Hans-Christoph Steiner
897a35aa76 enable lint TrustAllX509TrustManager as error 2018-08-17 10:10:00 +02:00
Hans-Christoph Steiner
896d4a788f enable lint PackageManagerGetSignatures as error 2018-08-17 10:10:00 +02:00
Hans-Christoph Steiner
4a684182ca enable lint "GetInstance" security check as error 2018-08-17 10:10:00 +02:00
Hans-Christoph Steiner
81b32120e9 fix UnusedResources errors left over from basic/full flavor split 2018-08-17 10:10:00 +02:00
Hans-Christoph Steiner
0e368c6d6e only disable lint in the basic flavor for UnusedResources
My hack before was actually always making exit with success, breaking the
CI runs :-/  I loathe gradle and groovy with a passion.
2018-08-17 10:09:59 +02:00
Hans-Christoph Steiner
c87f6a64f9 get "basic" flavor building and running 2018-06-18 16:46:26 +02:00
Hans-Christoph Steiner
d5d3abe2a3 fix lint "Implied default locale in case conversion"
find app/src/full/java/kellinwood/ -name \*.java |xargs sed -i 's,\.toLowerCase(),.toLowerCase(Locale.ROOT),g'
2018-06-06 21:09:39 +02:00
Hans-Christoph Steiner
7b679ef57c new version of lint is more aggressive at announcing UnusedResources
These are in fact needed:

  /export/share/code/fdroid/client/app/src/main/res/values/dimens.xml:25: Error: The resource R.dimen.fixed_width_padding appears to be unused [UnusedResources]
      <dimen name="fixed_width_padding">2dp</dimen>
             ~~~~~~~~~~~~~~~~~~~~~~~~~~
  /export/share/code/fdroid/client/app/src/main/res/values/styles.xml:162: Error: The resource R.style.SwapTheme_StartSwap appears to be unused [UnusedResources]
      <style name="SwapTheme.StartSwap" parent="AppThemeLight">
             ~~~~~~~~~~~~~~~~~~~~~~~~~~
  /export/share/code/fdroid/client/app/src/main/res/values/styles.xml:166: Error: The resource R.style.SwapTheme_StartSwap_Text appears to be unused [UnusedResources]
      <style name="SwapTheme.StartSwap.Text" parent="@style/SwapTheme.StartSwap">
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2018-04-19 16:27:41 +02:00
Hans-Christoph Steiner
6fbdd1210e update to the latest version of the Android support libraries
This requires bumping compile and built-tools verisons.
2018-04-19 15:51:43 +02:00
Hans-Christoph Steiner
db120c0f1f lint: make UnusedResources an error
!520
2017-05-31 17:29:40 +02:00
Hans-Christoph Steiner
e07e4fc223 convert strings to plurals, and make lint enforces this
Lots of languages really need the <plurals> tags to make sense, so
this also makes lint exit with an error when it finds strings that
should be <plurals>

closes #883
2017-05-16 10:39:16 +02:00
Hans-Christoph Steiner
6456f56ced hide some lint warnings that cannot be fixed 2017-05-11 09:38:59 +02:00
Hans-Christoph Steiner
186d1dbabb fix SetTextI18n lint warnings and set as error 2017-05-11 09:38:59 +02:00
Hans-Christoph Steiner
7702e72acb move lint config to lint.xml to enable ignoring specific files 2017-05-11 09:38:59 +02:00