From ff6a60ae26f5dc95b6ba4cb6af9c9269d0e5e5ae Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Wed, 15 Feb 2017 10:31:41 +1100 Subject: [PATCH] Make exception more explicit by including root cause and package name. By omitting the cause of the exception, we are getting sub-standard stack traces. I suspect where the root cause is, because it is only thrown when a `PackageManager.NameNotFoundException` is thrown, but it would help if that was in the ACRA reports to stop future investigators from having to track that down. Also add the name of the package which we searched for in the exception. Knowing which apk was being uninstalled is not particularly helpful for debugging, but knowing if it is `null` or `""` is important, because that means that the `app.packageName` variable is not populated correctly. --- app/src/main/java/org/fdroid/fdroid/AppDetails.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/AppDetails.java b/app/src/main/java/org/fdroid/fdroid/AppDetails.java index 1def0e6ed..e1996a13d 100644 --- a/app/src/main/java/org/fdroid/fdroid/AppDetails.java +++ b/app/src/main/java/org/fdroid/fdroid/AppDetails.java @@ -993,7 +993,7 @@ public class AppDetails extends AppCompatActivity { return apk; } catch (PackageManager.NameNotFoundException e) { e.printStackTrace(); - throw new IllegalStateException("Couldn't find app while installing"); + throw new IllegalStateException("Couldn't find installed apk for " + app.packageName, e); } }