Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use case-insensitive file extension comparison for Apk.isApk()

Browse Source 
foo.APK is valid and installable, though not recommended.  Without this,
foo.APK would be copied to /sdcard/Downloads, which seems wrong
This commit is contained in:
Hans-Christoph Steiner 2020-10-20 19:23:50 +02:00
parent 0797d82d67
commit fe45b33851
No known key found for this signature in database
GPG Key ID: 3E177817BA1B9BFA
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/fdroid/fdroid/data/Apk.java
View File

@ -10,10 +10,10 @@ import android.os.Build;
import android.os.Environment;
import android.os.Parcel;
import android.os.Parcelable;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import android.text.TextUtils;
import android.webkit.MimeTypeMap;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import com.fasterxml.jackson.annotation.JacksonInject;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
@ -24,6 +24,7 @@ import java.io.File;
import java.util.Collections;
import java.util.Date;
import java.util.HashSet;
import java.util.Locale;
/**
* Represents a single package of an application. This represents one particular
@ -598,6 +599,7 @@ public class Apk extends ValueObject implements Comparable<Apk>, Parcelable {
* @return true if this is an apk instead of a non-apk/media file
*/
public boolean isApk() {
return this.apkName == null || this.apkName.endsWith(".apk");
return apkName == null
|| apkName.substring(apkName.length() - 4).toLowerCase(Locale.ENGLISH).endsWith(".apk");
}
}