From fbc47c1428ea099b8ec2077fd5d85778f04c45b0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dominik=20Sch=C3=BCrmann?= <dominik@dominikschuermann.de>
Date: Sun, 27 Apr 2014 20:11:36 +0200
Subject: [PATCH] Show dialog if root access was denied

---
 res/values/strings.xml                         |  2 ++
 src/org/fdroid/fdroid/PreferencesActivity.java | 10 +++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/res/values/strings.xml b/res/values/strings.xml
index e003e5f07..560c9b42e 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -238,5 +238,7 @@
     
     <string name="requesting_root_access_title">Root access</string>
     <string name="requesting_root_access_body">Requesting root access…</string>
+    <string name="root_access_denied_title">Root access denied</string>
+    <string name="root_access_denied_body">Either your Android device is not rooted or you have denied root access for F-Droid.</string>
     
 </resources>
diff --git a/src/org/fdroid/fdroid/PreferencesActivity.java b/src/org/fdroid/fdroid/PreferencesActivity.java
index 61fd2cf15..7847f7bf1 100644
--- a/src/org/fdroid/fdroid/PreferencesActivity.java
+++ b/src/org/fdroid/fdroid/PreferencesActivity.java
@@ -25,6 +25,8 @@ import android.preference.PreferenceActivity;
 import android.preference.CheckBoxPreference;
 import android.preference.EditTextPreference;
 import android.preference.ListPreference;
+import android.app.AlertDialog;
+import android.app.ProgressDialog;
 import android.content.SharedPreferences;
 import android.content.SharedPreferences.OnSharedPreferenceChangeListener;
 import android.view.MenuItem;
@@ -186,11 +188,17 @@ public class PreferencesActivity extends PreferenceActivity implements
                                 editor.commit();
                                 pref.setChecked(true);
                             } else {
-                                // root access disallowed
+                                // root access denied
                                 SharedPreferences.Editor editor = pref.getSharedPreferences().edit();
                                 editor.putBoolean(Preferences.PREF_ROOT_INSTALLER, false);
                                 editor.commit();
                                 pref.setChecked(false);
+                                
+                                AlertDialog.Builder alertBuilder = new AlertDialog.Builder(PreferencesActivity.this);
+                                alertBuilder.setTitle(R.string.root_access_denied_title);
+                                alertBuilder.setMessage(PreferencesActivity.this.getString(R.string.root_access_denied_body));
+                                alertBuilder.setNeutralButton(android.R.string.ok, null);
+                                alertBuilder.create().show();
                             }
                         }
                     });