From f655f49aee34407e1cc61fad11c2e12aaa5c4d6e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sat, 23 Apr 2016 16:17:55 +0100
Subject: [PATCH] PMD: Enable and obey UnnecessaryConstructor

---
 .../main/java/org/fdroid/fdroid/localrepo/SwapService.java    | 4 ----
 config/pmd/rules.xml                                          | 1 +
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/app/src/main/java/org/fdroid/fdroid/localrepo/SwapService.java b/app/src/main/java/org/fdroid/fdroid/localrepo/SwapService.java
index 818b26725..a9aedff12 100644
--- a/app/src/main/java/org/fdroid/fdroid/localrepo/SwapService.java
+++ b/app/src/main/java/org/fdroid/fdroid/localrepo/SwapService.java
@@ -91,10 +91,6 @@ public class SwapService extends Service {
     @NonNull
     private final Set<String> appsToSwap = new HashSet<>();
 
-    public SwapService() {
-        super();
-    }
-
     /**
      * Where relevant, the state of the swap process will be saved to disk using preferences.
      * Note that this is not always useful, for example saving the "current wifi network" is
diff --git a/config/pmd/rules.xml b/config/pmd/rules.xml
index fbde9c171..cab42517c 100644
--- a/config/pmd/rules.xml
+++ b/config/pmd/rules.xml
@@ -17,4 +17,5 @@
     </rule>
     <rule ref="rulesets/java/optimizations.xml/PrematureDeclaration"/>
     <rule ref="rulesets/java/optimizations.xml/AddEmptyString"/>
+    <rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor"/>
 </ruleset>