From f602e4586cc0ad7f0c4489a6716b91b163c3434e Mon Sep 17 00:00:00 2001
From: Henrik Tunedal <tunedal@gmail.com>
Date: Thu, 3 Feb 2011 03:31:14 +0100
Subject: [PATCH] Improved logging of exceptions.

---
 src/org/fdroid/fdroid/AppDetails.java     | 3 ++-
 src/org/fdroid/fdroid/DB.java             | 7 ++++---
 src/org/fdroid/fdroid/RepoXMLHandler.java | 4 ++--
 src/org/fdroid/fdroid/UpdateService.java  | 4 ++--
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java
index ed89ee8f2..e9e0b9440 100644
--- a/src/org/fdroid/fdroid/AppDetails.java
+++ b/src/org/fdroid/fdroid/AppDetails.java
@@ -526,7 +526,8 @@ public class AppDetails extends ListActivity {
                         }
                     }
                 } catch (Exception e) {
-                    Log.d("FDroid", "Download failed - " + e.getMessage());
+                    Log.e("FDroid", "Download failed:\n"
+                            + Log.getStackTraceString(e));
                     Message msg = new Message();
                     msg.obj = e.getMessage();
                     download_error_handler.sendMessage(msg);
diff --git a/src/org/fdroid/fdroid/DB.java b/src/org/fdroid/fdroid/DB.java
index b90e14cc6..cf705b0c6 100644
--- a/src/org/fdroid/fdroid/DB.java
+++ b/src/org/fdroid/fdroid/DB.java
@@ -281,7 +281,8 @@ public class DB {
             // Also try and delete the old one, from versions 0.13 and earlier.
             ctx.deleteDatabase("fdroid_db");
         } catch (Exception ex) {
-            Log.d("FDroid", "Exception in DB.delete: " + ex.getMessage());
+            Log.e("FDroid", "Exception in DB.delete:\n"
+                    + Log.getStackTraceString(ex));
         }
     }
 
@@ -401,8 +402,8 @@ public class DB {
             }
 
         } catch (Exception e) {
-            Log.d("FDroid", "Exception during database reading - "
-                    + e.getMessage() + " ... " + e.toString());
+            Log.e("FDroid", "Exception during database reading:\n"
+                    + Log.getStackTraceString(e));
         } finally {
             if (c != null) {
                 c.close();
diff --git a/src/org/fdroid/fdroid/RepoXMLHandler.java b/src/org/fdroid/fdroid/RepoXMLHandler.java
index dbfd6c03e..471c0a5bd 100644
--- a/src/org/fdroid/fdroid/RepoXMLHandler.java
+++ b/src/org/fdroid/fdroid/RepoXMLHandler.java
@@ -321,8 +321,8 @@ public class RepoXMLHandler extends DefaultHandler {
                     }
 
                 } catch (Exception e) {
-                    Log.d("FDroid", "Exception updating from " + repo.address
-                            + " - " + e.toString());
+                    Log.e("FDroid", "Exception updating from " + repo.address
+                            + ":\n" + Log.getStackTraceString(e));
                     return false;
                 } finally {
                     ctx.deleteFile("tempindex.xml");
diff --git a/src/org/fdroid/fdroid/UpdateService.java b/src/org/fdroid/fdroid/UpdateService.java
index 49d2131a6..7e91c02be 100644
--- a/src/org/fdroid/fdroid/UpdateService.java
+++ b/src/org/fdroid/fdroid/UpdateService.java
@@ -135,8 +135,8 @@ public class UpdateService extends Service {
                     }
 
                 } catch (Exception e) {
-                    Log.d("FDroid", "Exception during handleCommand() - "
-                            + e.getMessage());
+                    Log.e("FDroid", "Exception during handleCommand():\n"
+                            + Log.getStackTraceString(e));
                 } finally {
                     if (db != null)
                         db.close();