From f4a7aa7ced9a0c1aab1a9e892d1ea27f2d3fe626 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 7 May 2013 19:55:08 +0200 Subject: [PATCH] Use vercodes, not version strings! Different versions might have the same names, but different codes. That doesn't happen often, but could happen. --- src/org/fdroid/fdroid/AppDetails.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java index acf560e24..f0819cdf0 100644 --- a/src/org/fdroid/fdroid/AppDetails.java +++ b/src/org/fdroid/fdroid/AppDetails.java @@ -473,8 +473,8 @@ public class AppDetails extends ListActivity { @Override protected void onListItemClick(ListView l, View v, int position, long id) { curapk = app.apks.get(position - l.getHeaderViewsCount()); - if (app.installedVersion != null - && app.installedVersion.equals(curapk.version)) { + if (app.installedVerCode != 0 + && app.installedVerCode == curapk.vercode) { removeApk(app.id); } else { install();