Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make updates/installed final to slightly simplify code.

Browse Source
This commit is contained in:
Peter Serwylo 2017-02-24 12:43:44 +11:00 committed by mvp76
parent a2997747af
commit ef7d8dfce9
1 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/src/main/java/org/fdroid/fdroid/NotificationHelper.java
View File

@ -53,8 +53,8 @@ class NotificationHelper {
private final NotificationManagerCompat notificationManager; private final NotificationManagerCompat notificationManager;
private final AppUpdateStatusManager appUpdateStatusManager; private final AppUpdateStatusManager appUpdateStatusManager;
private final DisplayImageOptions displayImageOptions; private final DisplayImageOptions displayImageOptions;
private ArrayList<AppUpdateStatusManager.AppUpdateStatus> updates; private final ArrayList<AppUpdateStatusManager.AppUpdateStatus> updates = new ArrayList<>();
private ArrayList<AppUpdateStatusManager.AppUpdateStatus> installed; private final ArrayList<AppUpdateStatusManager.AppUpdateStatus> installed = new ArrayList<>();
NotificationHelper(Context context) { NotificationHelper(Context context) {
this.context = context; this.context = context;
@ -151,22 +151,18 @@ class NotificationHelper {
return Build.VERSION.SDK_INT >= Build.VERSION_CODES.N; return Build.VERSION.SDK_INT >= Build.VERSION_CODES.N;
} }
/**
* Populate {@link NotificationHelper#updates} and {@link NotificationHelper#installed} with
* the relevant status entries from the {@link AppUpdateStatusManager}.
*/
private void updateStatusLists() { private void updateStatusLists() {
if (!notificationManager.areNotificationsEnabled()) { if (!notificationManager.areNotificationsEnabled()) {
return; return;
} }
// Get the list of updates and installed available updates.clear();
if (updates == null) { installed.clear();
updates = new ArrayList<>();
} else {
updates.clear();
}
if (installed == null) {
installed = new ArrayList<>();
} else {
installed.clear();
}
for (AppUpdateStatusManager.AppUpdateStatus entry : appUpdateStatusManager.getAll()) { for (AppUpdateStatusManager.AppUpdateStatus entry : appUpdateStatusManager.getAll()) {
if (entry.status == AppUpdateStatusManager.Status.Installed) { if (entry.status == AppUpdateStatusManager.Status.Installed) {
installed.add(entry); installed.add(entry);