From ebb6d43cbb782a1e82f57b05c980f6a2a65d4b1d Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Thu, 11 Aug 2016 23:11:50 +1000 Subject: [PATCH] Remove dead code AS picked up that the statement is always false, so the body of the if is never executed. This is indeed the case, because the constructor assigns the object which is being checked for null. --- .../fdroid/privileged/views/InstallConfirmActivity.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/privileged/views/InstallConfirmActivity.java b/app/src/main/java/org/fdroid/fdroid/privileged/views/InstallConfirmActivity.java index c7f443a7d..ed9137b53 100644 --- a/app/src/main/java/org/fdroid/fdroid/privileged/views/InstallConfirmActivity.java +++ b/app/src/main/java/org/fdroid/fdroid/privileged/views/InstallConfirmActivity.java @@ -56,8 +56,6 @@ import org.fdroid.fdroid.data.Schema; */ public class InstallConfirmActivity extends FragmentActivity implements OnCancelListener, OnClickListener { - private static final int RESULT_CANNOT_PARSE = RESULT_FIRST_USER + 1; - private Intent intent; private AppDiff appDiff; @@ -196,10 +194,6 @@ public class InstallConfirmActivity extends FragmentActivity implements OnCancel app = AppProvider.Helper.findByPackageName(getContentResolver(), apk.packageName); appDiff = new AppDiff(getPackageManager(), apk); - if (appDiff.pkgInfo == null) { - setResult(RESULT_CANNOT_PARSE, intent); - finish(); - } setContentView(R.layout.install_start);