From da4c97c4c2ce45ffe8529c458e57880583ce7b62 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reimar=20D=C3=B6ffinger?= <Reimar.Doeffinger@gmx.de>
Date: Mon, 20 Aug 2018 13:25:07 +0200
Subject: [PATCH] Add missing "focusable" attributes.

Fixes lint warnings and improves keyboard navigation
a little bit.
---
 app/src/main/res/layout/app_card_horizontal.xml     | 3 ++-
 app/src/main/res/layout/app_card_large.xml          | 3 ++-
 app/src/main/res/layout/app_card_list_item.xml      | 3 ++-
 app/src/main/res/layout/app_details2_links.xml      | 3 ++-
 app/src/main/res/layout/app_list_item.xml           | 3 ++-
 app/src/main/res/layout/installed_app_list_item.xml | 3 ++-
 6 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/app/src/main/res/layout/app_card_horizontal.xml b/app/src/main/res/layout/app_card_horizontal.xml
index 9514bee59..e20f1a100 100644
--- a/app/src/main/res/layout/app_card_horizontal.xml
+++ b/app/src/main/res/layout/app_card_horizontal.xml
@@ -5,7 +5,8 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:foreground="?attr/selectableItemBackground"
-    android:clickable="true">
+    android:clickable="true"
+    android:focusable="true">
 
     <android.support.constraint.ConstraintLayout
         android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/app_card_large.xml b/app/src/main/res/layout/app_card_large.xml
index 405453a1b..cd8b57ad4 100644
--- a/app/src/main/res/layout/app_card_large.xml
+++ b/app/src/main/res/layout/app_card_large.xml
@@ -5,7 +5,8 @@
     android:layout_width="match_parent"
     android:layout_height="220dp"
     android:foreground="?attr/selectableItemBackground"
-    android:clickable="true">
+    android:clickable="true"
+    android:focusable="true">
 
     <android.support.constraint.ConstraintLayout
         android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/app_card_list_item.xml b/app/src/main/res/layout/app_card_list_item.xml
index a781050d3..7bf92f98d 100644
--- a/app/src/main/res/layout/app_card_list_item.xml
+++ b/app/src/main/res/layout/app_card_list_item.xml
@@ -5,7 +5,8 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:foreground="?attr/selectableItemBackground"
-    android:clickable="true">
+    android:clickable="true"
+    android:focusable="true">
 
     <android.support.constraint.ConstraintLayout
         android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/app_details2_links.xml b/app/src/main/res/layout/app_details2_links.xml
index 59ba5da7b..d953f3552 100644
--- a/app/src/main/res/layout/app_details2_links.xml
+++ b/app/src/main/res/layout/app_details2_links.xml
@@ -12,7 +12,8 @@
     android:layout_marginBottom="@dimen/details_activity__collapsable_lists__padding__vertical"
     android:clickable="true"
     android:orientation="vertical"
-    tools:ignore="UnusedAttribute">
+    tools:ignore="UnusedAttribute"
+    android:focusable="true">
 
     <!-- This frame layout is only for showing the material-design-like background ripple when
          selecting the TextView. -->
diff --git a/app/src/main/res/layout/app_list_item.xml b/app/src/main/res/layout/app_list_item.xml
index 76f60c7c2..cf0fa98d8 100644
--- a/app/src/main/res/layout/app_list_item.xml
+++ b/app/src/main/res/layout/app_list_item.xml
@@ -6,7 +6,8 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:clickable="true"
-    android:background="?attr/selectableItemBackground">
+    android:background="?attr/selectableItemBackground"
+    android:focusable="true">
 
     <!-- Ignore ContentDescription because it is kind of meaningless to have TTS read out "App icon"
          when it will inevitably read out the name of the app straight after. -->
diff --git a/app/src/main/res/layout/installed_app_list_item.xml b/app/src/main/res/layout/installed_app_list_item.xml
index b6c679fdd..e65779c86 100644
--- a/app/src/main/res/layout/installed_app_list_item.xml
+++ b/app/src/main/res/layout/installed_app_list_item.xml
@@ -9,7 +9,8 @@
     android:paddingTop="8dp"
     android:paddingBottom="8dp"
     android:clickable="true"
-    android:background="?attr/selectableItemBackground">
+    android:background="?attr/selectableItemBackground"
+    android:focusable="true">
 
     <!-- Ignore ContentDescription because it is kind of meaningless to have TTS read out "App icon"
          when it will inevitably read out the name of the app straight after. -->