From 0984a93133cc1fc30c7fc31fb9605d48fd88fc20 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Sch=C3=BCrmann?= Date: Fri, 13 May 2016 00:31:24 +0300 Subject: [PATCH] Ignore lint for GET_UNINSTALLED_PACKAGES Lint says that only GET_META_DATA and GET_SHARED_LIBRARY_FILES are allowed. This contradicts Android's documentation where GET_UNINSTALLED_PACKAGES is also allowed. Fixes #605 --- .../java/org/fdroid/fdroid/installer/PrivilegedInstaller.java | 1 + .../main/java/org/fdroid/fdroid/privileged/views/AppDiff.java | 1 + 2 files changed, 2 insertions(+) diff --git a/app/src/main/java/org/fdroid/fdroid/installer/PrivilegedInstaller.java b/app/src/main/java/org/fdroid/fdroid/installer/PrivilegedInstaller.java index b24adb690..801164ace 100644 --- a/app/src/main/java/org/fdroid/fdroid/installer/PrivilegedInstaller.java +++ b/app/src/main/java/org/fdroid/fdroid/installer/PrivilegedInstaller.java @@ -241,6 +241,7 @@ public class PrivilegedInstaller extends Installer { throws InstallFailedException { ApplicationInfo appInfo; try { + //noinspection WrongConstant (lint is actually wrong here!) appInfo = mPm.getApplicationInfo(packageName, PackageManager.GET_UNINSTALLED_PACKAGES); } catch (PackageManager.NameNotFoundException e) { Log.w(TAG, "Failed to get ApplicationInfo for uninstalling"); diff --git a/app/src/main/java/org/fdroid/fdroid/privileged/views/AppDiff.java b/app/src/main/java/org/fdroid/fdroid/privileged/views/AppDiff.java index 1e5f1f687..096f0290b 100644 --- a/app/src/main/java/org/fdroid/fdroid/privileged/views/AppDiff.java +++ b/app/src/main/java/org/fdroid/fdroid/privileged/views/AppDiff.java @@ -66,6 +66,7 @@ public class AppDiff { // This is a little convoluted because we want to get all uninstalled // apps, but this may include apps with just data, and if it is just // data we still want to count it as "installed". + //noinspection WrongConstant (lint is actually wrong here!) mInstalledAppInfo = mPm.getApplicationInfo(pkgName, PackageManager.GET_UNINSTALLED_PACKAGES); if ((mInstalledAppInfo.flags & ApplicationInfo.FLAG_INSTALLED) == 0) {