From d77fce9d8051252ac95b799f96bb47f501d376c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Wed, 30 Sep 2015 11:29:04 -0700 Subject: [PATCH] Don't use DownloadManager on Android 2.3 Fixes apk downloads crashing on 2.3 devices as spotted in the comments at issue #421. --- F-Droid/src/org/fdroid/fdroid/net/DownloaderFactory.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/F-Droid/src/org/fdroid/fdroid/net/DownloaderFactory.java b/F-Droid/src/org/fdroid/fdroid/net/DownloaderFactory.java index 672071a82..a485592c3 100644 --- a/F-Droid/src/org/fdroid/fdroid/net/DownloaderFactory.java +++ b/F-Droid/src/org/fdroid/fdroid/net/DownloaderFactory.java @@ -72,9 +72,12 @@ public class DownloaderFactory { /** * Tests to see if we can use Android's DownloadManager to download the APK, instead of * a downloader returned from DownloadFactory. + * + * We require ICE_CREAM_SANDWICH (4.0). The DownloadManager does exist on + * 2.3.X, but it lacks HTTPS support. */ private static boolean canUseDownloadManager(URL url) { - return Build.VERSION.SDK_INT > Build.VERSION_CODES.FROYO && !isOnionAddress(url); + return Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH && !isOnionAddress(url); } }