From e965e9762331993621f4d0b20a8d78c0d210da95 Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Fri, 12 May 2017 12:16:55 +1000 Subject: [PATCH] Force each stacked notification to have a different requestCode. This ensures that the `PendingIntent.FLAG_UPDATE_CURRENT` doesn't continually override earlier intents with the last app to be notified. This could probably equally be done by leaving the request code as 0 and removing the FLAG_UPDATE_CURRENT out, however it seems much more semantic to have a separate request code for each different pending intent. Fixes #1021. --- app/src/main/java/org/fdroid/fdroid/AppUpdateStatusManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/AppUpdateStatusManager.java b/app/src/main/java/org/fdroid/fdroid/AppUpdateStatusManager.java index 9ce22abb9..8e74558a6 100644 --- a/app/src/main/java/org/fdroid/fdroid/AppUpdateStatusManager.java +++ b/app/src/main/java/org/fdroid/fdroid/AppUpdateStatusManager.java @@ -410,7 +410,7 @@ public final class AppUpdateStatusManager { return TaskStackBuilder.create(context) .addParentStack(AppDetails2.class) .addNextIntent(notifyIntent) - .getPendingIntent(0, PendingIntent.FLAG_UPDATE_CURRENT); + .getPendingIntent(apk.packageName.hashCode(), PendingIntent.FLAG_UPDATE_CURRENT); } private PendingIntent getAppErrorIntent(AppUpdateStatus entry) {