From d3f7e9555eef7f8d4f80870b70c6b94ff056260c Mon Sep 17 00:00:00 2001 From: relan Date: Tue, 22 Sep 2015 16:26:49 +0300 Subject: [PATCH] Fix repo_item layout parameters resolution See http://www.doubleencore.com/2013/05/layout-inflation-as-intended --- F-Droid/src/org/fdroid/fdroid/views/RepoAdapter.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/F-Droid/src/org/fdroid/fdroid/views/RepoAdapter.java b/F-Droid/src/org/fdroid/fdroid/views/RepoAdapter.java index 51c2a93fe..1b71b754b 100644 --- a/F-Droid/src/org/fdroid/fdroid/views/RepoAdapter.java +++ b/F-Droid/src/org/fdroid/fdroid/views/RepoAdapter.java @@ -53,7 +53,7 @@ public class RepoAdapter extends CursorAdapter { @Override public View newView(Context context, Cursor cursor, ViewGroup parent) { - View view = inflater.inflate(R.layout.repo_item, null); + View view = inflater.inflate(R.layout.repo_item, parent, false); CompoundButton switchView = addSwitchToView(view, context); setupView(cursor, view, switchView); return view; @@ -95,11 +95,9 @@ public class RepoAdapter extends CursorAdapter { (RelativeLayout.LayoutParams)nameView.getLayoutParams(); nameViewLayout.addRule(LayoutCompat.RelativeLayout.START_OF, switchView.getId()); - // If we set the signed view to GONE instead of INVISIBLE, then the - // height of each list item varies. TextView signedView = (TextView) view.findViewById(R.id.repo_unsigned); if (repo.isSigned()) { - signedView.setVisibility(View.INVISIBLE); + signedView.setVisibility(View.GONE); } else if (repo.isSignedButUnverified()) { signedView.setText(R.string.unverified); signedView.setTextColor(view.getResources().getColor(R.color.unverified));