From d2018517841ded9f8b3598201e609dc690599ea6 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Thu, 28 Mar 2019 21:21:17 +0100 Subject: [PATCH] fix crash when ExternalStorage fails to find something java.lang.IllegalArgumentException: Failed to find storage device at null at android.os.Environment.isExternalStorageRemovable(Environment.java:859) at org.fdroid.fdroid.views.main.NearbyViewBinder.(NearbyViewBinder.java:85) at org.fdroid.fdroid.views.main.MainViewController.bindSwapView(MainViewController.java:64) at org.fdroid.fdroid.views.main.MainViewAdapter.onCreateViewHolder(MainViewAdapter.java:94) at org.fdroid.fdroid.views.main.MainViewAdapter.onCreateViewHolder(MainViewAdapter.java:47) at android.support.v7.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:6685) --- .../fdroid/fdroid/views/main/MainViewController.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/app/src/full/java/org/fdroid/fdroid/views/main/MainViewController.java b/app/src/full/java/org/fdroid/fdroid/views/main/MainViewController.java index 447ec21f1..277f5d41d 100644 --- a/app/src/full/java/org/fdroid/fdroid/views/main/MainViewController.java +++ b/app/src/full/java/org/fdroid/fdroid/views/main/MainViewController.java @@ -60,8 +60,17 @@ class MainViewController extends RecyclerView.ViewHolder { new CategoriesViewBinder(activity, frame); } + /** + * {@link android.os.Environment#isExternalStorageRemovable()} sometimes + * throughs {@link IllegalArgumentException}s when it can't find the + * storage. + */ public void bindSwapView() { - new NearbyViewBinder(activity, frame); + try { + new NearbyViewBinder(activity, frame); + } catch (IllegalArgumentException e) { + e.printStackTrace(); + } } /**