From d042ed75085d79a1949abb89290f9956e8f0100a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Thu, 12 Dec 2013 00:13:09 +0100 Subject: [PATCH] Multiple appends are better than an append of a concatenation --- src/org/fdroid/fdroid/AppDetails.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/org/fdroid/fdroid/AppDetails.java b/src/org/fdroid/fdroid/AppDetails.java index e682bc8a5..81cd937ce 100644 --- a/src/org/fdroid/fdroid/AppDetails.java +++ b/src/org/fdroid/fdroid/AppDetails.java @@ -474,8 +474,7 @@ public class AppDetails extends ListActivity { if (listNum == -1) { output.append("\t• "); } else { - output.append("\t" + Integer.toString(listNum) - + ". "); + output.append("\t").append(Integer.toString(listNum)).append(". "); listNum++; } } else { @@ -510,7 +509,7 @@ public class AppDetails extends ListActivity { String permissionName = permissions.next(); try { Permission permission = new Permission(this, permissionName); - sb.append("\t• " + permission.getName() + '\n'); + sb.append("\t• ").append(permission.getName()).append('\n'); } catch (NameNotFoundException e) { if (permissionName.equals("ACCESS_SUPERUSER")) { sb.append("\t• Full permissions to all device features and storage\n"); @@ -537,7 +536,7 @@ public class AppDetails extends ListActivity { for (String af : app.antiFeatures) { String afdesc = descAntiFeature(af); if (afdesc != null) { - sb.append("\t• " + afdesc + "\n"); + sb.append("\t• ").append(afdesc).append("\n"); } } if (sb.length() > 0) {