Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RepoAdapter: code cleanup

Browse Source 
Remove unused code and simplify to only present args that are used. This is
remnants from:

fdroidclient#490
fdroidclient#606
fdroidclient!295
fdroidclient!242
This commit is contained in:
Hans-Christoph Steiner 2019-02-19 12:49:47 +01:00
parent afe6de94a0
commit cf9a6b851d
2 changed files with 4 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java
View File

@ -63,7 +63,6 @@ import org.fdroid.fdroid.IndexUpdater;
import org.fdroid.fdroid.R; import org.fdroid.fdroid.R;
import org.fdroid.fdroid.UpdateService; import org.fdroid.fdroid.UpdateService;
import org.fdroid.fdroid.Utils; import org.fdroid.fdroid.Utils;
import org.fdroid.fdroid.compat.CursorAdapterCompat;
import org.fdroid.fdroid.data.NewRepoConfig; import org.fdroid.fdroid.data.NewRepoConfig;
import org.fdroid.fdroid.data.Repo; import org.fdroid.fdroid.data.Repo;
import org.fdroid.fdroid.data.RepoProvider; import org.fdroid.fdroid.data.RepoProvider;
@ -114,7 +113,7 @@ public class ManageReposActivity extends AppCompatActivity
getSupportActionBar().setDisplayHomeAsUpEnabled(true); getSupportActionBar().setDisplayHomeAsUpEnabled(true);
final ListView repoList = (ListView) findViewById(R.id.list); final ListView repoList = (ListView) findViewById(R.id.list);
repoAdapter = RepoAdapter.create(this, null, CursorAdapterCompat.FLAG_AUTO_REQUERY); repoAdapter = new RepoAdapter(this);
repoAdapter.setEnabledListener(this); repoAdapter.setEnabledListener(this);
repoList.setAdapter(repoAdapter); repoList.setAdapter(repoAdapter);
repoList.setOnItemClickListener(new AdapterView.OnItemClickListener() { repoList.setOnItemClickListener(new AdapterView.OnItemClickListener() {

20
app/src/main/java/org/fdroid/fdroid/views/RepoAdapter.java
View File

@ -9,6 +9,7 @@ import android.view.ViewGroup;
import android.widget.CompoundButton; import android.widget.CompoundButton;
import android.widget.TextView; import android.widget.TextView;
import org.fdroid.fdroid.R; import org.fdroid.fdroid.R;
import org.fdroid.fdroid.compat.CursorAdapterCompat;
import org.fdroid.fdroid.data.Repo; import org.fdroid.fdroid.data.Repo;
public class RepoAdapter extends CursorAdapter { public class RepoAdapter extends CursorAdapter {
@ -21,23 +22,8 @@ public class RepoAdapter extends CursorAdapter {
private EnabledListener enabledListener; private EnabledListener enabledListener;
public static RepoAdapter create(Context context, Cursor cursor, int flags) { RepoAdapter(Context context) {
return new RepoAdapter(context, cursor, flags); super(context, null, CursorAdapterCompat.FLAG_AUTO_REQUERY);
}
private RepoAdapter(Context context, Cursor c, int flags) {
super(context, c, flags);
inflater = LayoutInflater.from(context);
}
public RepoAdapter(Context context, Cursor c, boolean autoRequery) {
super(context, c, autoRequery);
inflater = LayoutInflater.from(context);
}
@SuppressWarnings("deprecation")
private RepoAdapter(Context context, Cursor c) {
super(context, c);
inflater = LayoutInflater.from(context); inflater = LayoutInflater.from(context);
} }