diff --git a/app/src/main/java/org/fdroid/fdroid/acra/CrashReportActivity.java b/app/src/main/java/org/fdroid/fdroid/acra/CrashReportActivity.java index 9423f1fd9..c45ac3bd2 100644 --- a/app/src/main/java/org/fdroid/fdroid/acra/CrashReportActivity.java +++ b/app/src/main/java/org/fdroid/fdroid/acra/CrashReportActivity.java @@ -9,6 +9,8 @@ import org.fdroid.fdroid.R; import androidx.appcompat.app.AlertDialog; +import com.google.android.material.textfield.TextInputLayout; + public class CrashReportActivity extends BaseCrashReportDialog implements DialogInterface.OnDismissListener, DialogInterface.OnClickListener { @@ -30,7 +32,8 @@ public class CrashReportActivity extends BaseCrashReportDialog dialog.setOnDismissListener(this); dialog.show(); - comment = (EditText) dialog.findViewById(android.R.id.input); + TextInputLayout commentLayout = dialog.findViewById(android.R.id.input); + comment = commentLayout.getEditText(); if (savedInstanceState != null) { comment.setText(savedInstanceState.getString(STATE_COMMENT)); } diff --git a/app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java b/app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java index e2ff996c9..0036b224d 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java +++ b/app/src/main/java/org/fdroid/fdroid/views/ManageReposActivity.java @@ -50,8 +50,20 @@ import android.widget.ListView; import android.widget.TextView; import android.widget.Toast; +import androidx.annotation.NonNull; +import androidx.appcompat.app.AlertDialog; +import androidx.appcompat.app.AppCompatActivity; +import androidx.appcompat.widget.Toolbar; +import androidx.core.app.NavUtils; +import androidx.core.app.TaskStackBuilder; +import androidx.core.content.ContextCompat; +import androidx.loader.app.LoaderManager; +import androidx.loader.content.CursorLoader; +import androidx.loader.content.Loader; + import com.google.android.material.appbar.MaterialToolbar; import com.google.android.material.dialog.MaterialAlertDialogBuilder; +import com.google.android.material.textfield.TextInputLayout; import org.fdroid.fdroid.AddRepoIntentService; import org.fdroid.fdroid.FDroidApp; @@ -75,17 +87,6 @@ import java.util.Arrays; import java.util.HashMap; import java.util.Locale; -import androidx.annotation.NonNull; -import androidx.appcompat.app.AlertDialog; -import androidx.appcompat.app.AppCompatActivity; -import androidx.appcompat.widget.Toolbar; -import androidx.core.app.NavUtils; -import androidx.core.app.TaskStackBuilder; -import androidx.core.content.ContextCompat; -import androidx.loader.app.LoaderManager; -import androidx.loader.content.CursorLoader; -import androidx.loader.content.Loader; - public class ManageReposActivity extends AppCompatActivity implements LoaderManager.LoaderCallbacks, RepoAdapter.EnabledListener { private static final String TAG = "ManageReposActivity"; @@ -296,8 +297,10 @@ public class ManageReposActivity extends AppCompatActivity final View view = getLayoutInflater().inflate(R.layout.addrepo, null); MaterialAlertDialogBuilder addRepoDialogBuilder = new MaterialAlertDialogBuilder(context); addRepoDialogBuilder.setView(view); - final EditText uriEditText = (EditText) view.findViewById(R.id.edit_uri); - final EditText fingerprintEditText = (EditText) view.findViewById(R.id.edit_fingerprint); + final TextInputLayout uriEditTextLayout = view.findViewById(R.id.edit_uri); + final TextInputLayout fingerprintEditTextLayout = view.findViewById(R.id.edit_fingerprint); + final EditText uriEditText = uriEditTextLayout.getEditText(); + final EditText fingerprintEditText = fingerprintEditTextLayout.getEditText(); addRepoDialogBuilder.setTitle(R.string.repo_add_title); addRepoDialogBuilder.setNegativeButton(getString(R.string.cancel), new DialogInterface.OnClickListener() { diff --git a/app/src/main/java/org/fdroid/fdroid/views/RepoDetailsActivity.java b/app/src/main/java/org/fdroid/fdroid/views/RepoDetailsActivity.java index 94b83b92b..a86d8ff21 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/RepoDetailsActivity.java +++ b/app/src/main/java/org/fdroid/fdroid/views/RepoDetailsActivity.java @@ -27,6 +27,7 @@ import android.widget.TextView; import android.widget.Toast; import com.google.android.material.appbar.MaterialToolbar; +import com.google.android.material.textfield.TextInputLayout; import org.fdroid.fdroid.FDroidApp; import org.fdroid.fdroid.NfcHelper; @@ -424,8 +425,10 @@ public class RepoDetailsActivity extends AppCompatActivity { public void showChangePasswordDialog(final View parentView) { final View view = getLayoutInflater().inflate(R.layout.login, null); final AlertDialog credentialsDialog = new AlertDialog.Builder(this).setView(view).create(); - final EditText nameInput = view.findViewById(R.id.edit_name); - final EditText passwordInput = view.findViewById(R.id.edit_password); + final TextInputLayout nameInputLayout = view.findViewById(R.id.edit_name); + final TextInputLayout passwordInputLayout = view.findViewById(R.id.edit_password); + final EditText nameInput = nameInputLayout.getEditText(); + final EditText passwordInput = passwordInputLayout.getEditText(); nameInput.setText(repo.username); passwordInput.requestFocus(); diff --git a/app/src/main/res/layout/addrepo.xml b/app/src/main/res/layout/addrepo.xml index 53d193574..a115e158a 100644 --- a/app/src/main/res/layout/addrepo.xml +++ b/app/src/main/res/layout/addrepo.xml @@ -3,11 +3,11 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:paddingLeft="24dp" android:paddingStart="24dp" - android:paddingRight="24dp" + android:paddingLeft="24dp" + android:paddingTop="20dp" android:paddingEnd="24dp" - android:paddingTop="20dp"> + android:paddingRight="24dp"> - - - + android:layout_margin="4dp" + android:hint="@string/repo_add_url" + android:text="@string/https"> - + - + + + + android:hint="@string/repo_add_fingerprint" + android:typeface="monospace"> + + + + - + diff --git a/app/src/main/res/layout/crash_report_dialog.xml b/app/src/main/res/layout/crash_report_dialog.xml index 9079d3b94..e98415556 100644 --- a/app/src/main/res/layout/crash_report_dialog.xml +++ b/app/src/main/res/layout/crash_report_dialog.xml @@ -4,13 +4,13 @@ android:layout_height="match_parent"> + android:paddingBottom="24dp"> - + android:layout_marginTop="20dp"> + + + \ No newline at end of file diff --git a/app/src/main/res/layout/login.xml b/app/src/main/res/layout/login.xml index 277068ca3..26cf1bc3d 100644 --- a/app/src/main/res/layout/login.xml +++ b/app/src/main/res/layout/login.xml @@ -3,40 +3,50 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:paddingLeft="24dp" android:paddingStart="24dp" - android:paddingRight="24dp" + android:paddingLeft="24dp" + android:paddingTop="20dp" android:paddingEnd="24dp" - android:paddingTop="20dp"> + android:paddingRight="24dp"> - - - + android:layout_margin="4dp" + android:hint="@string/login_name"> - + - + + + + android:layout_margin="4dp" + android:hint="@string/login_password"> + + + + + \ No newline at end of file