From c947f24495839e5c348aa89d987e900034495c3d Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Tue, 24 May 2016 22:46:07 +0200 Subject: [PATCH] simple test for WifiStateChangeService.formatIpAddress() 94f79a6438c7021db9c02003865c17f3a0da1718 made me want to be sure --- .../fdroid/net/WifiStateChangeService.java | 2 +- .../net/WifiStateChangeServiceTest.java | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 app/src/test/java/org/fdroid/fdroid/net/WifiStateChangeServiceTest.java diff --git a/app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java b/app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java index d0560a052..75d76c5eb 100644 --- a/app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java +++ b/app/src/main/java/org/fdroid/fdroid/net/WifiStateChangeService.java @@ -229,7 +229,7 @@ public class WifiStateChangeService extends IntentService { } } - private String formatIpAddress(int ipAddress) { + static String formatIpAddress(int ipAddress) { if (ipAddress == 0) { return null; } diff --git a/app/src/test/java/org/fdroid/fdroid/net/WifiStateChangeServiceTest.java b/app/src/test/java/org/fdroid/fdroid/net/WifiStateChangeServiceTest.java new file mode 100644 index 000000000..365b81ffc --- /dev/null +++ b/app/src/test/java/org/fdroid/fdroid/net/WifiStateChangeServiceTest.java @@ -0,0 +1,20 @@ +package org.fdroid.fdroid.net; + +import org.junit.Test; + +import java.net.InetAddress; +import java.net.UnknownHostException; + +public class WifiStateChangeServiceTest { + + @Test + public void testFormatIpAddress() throws UnknownHostException { + for (long i = Integer.MIN_VALUE; i <= Integer.MAX_VALUE; i += 98273) { + String ip = WifiStateChangeService.formatIpAddress((int) i); + InetAddress.getByName(ip); + } + InetAddress.getByName(WifiStateChangeService.formatIpAddress(Integer.MAX_VALUE)); + InetAddress.getByName(WifiStateChangeService.formatIpAddress(Integer.MIN_VALUE)); + InetAddress.getByName(WifiStateChangeService.formatIpAddress(0)); + } +}