Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix PMD "Field has the same name as a method"

Browse Source
This commit is contained in:
Hans-Christoph Steiner 2020-01-02 20:28:35 +01:00
parent 3b67aa1a60
commit c7f3910472
No known key found for this signature in database
GPG Key ID: 3E177817BA1B9BFA
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/fdroid/fdroid/data/FDroidProvider.java
View File

@ -27,7 +27,7 @@ public abstract class FDroidProvider extends ContentProvider {
static final int CODE_LIST = 1; static final int CODE_LIST = 1;
static final int CODE_SINGLE = 2; static final int CODE_SINGLE = 2;
private boolean isApplyingBatch; private boolean applyingBatch;
protected abstract String getTableName(); protected abstract String getTableName();
@ -47,7 +47,7 @@ public abstract class FDroidProvider extends ContentProvider {
* Based on http://stackoverflow.com/a/15886915. * Based on http://stackoverflow.com/a/15886915.
*/ */
protected final boolean isApplyingBatch() { protected final boolean isApplyingBatch() {
return this.isApplyingBatch; return this.applyingBatch;
} }
@NonNull @NonNull
@ -55,7 +55,7 @@ public abstract class FDroidProvider extends ContentProvider {
public ContentProviderResult[] applyBatch(@NonNull ArrayList<ContentProviderOperation> operations) public ContentProviderResult[] applyBatch(@NonNull ArrayList<ContentProviderOperation> operations)
throws OperationApplicationException { throws OperationApplicationException {
ContentProviderResult[] result = null; ContentProviderResult[] result = null;
isApplyingBatch = true; applyingBatch = true;
final SQLiteDatabase db = db(); final SQLiteDatabase db = db();
db.beginTransaction(); db.beginTransaction();
try { try {
@ -63,7 +63,7 @@ public abstract class FDroidProvider extends ContentProvider {
db.setTransactionSuccessful(); db.setTransactionSuccessful();
} finally { } finally {
db.endTransaction(); db.endTransaction();
isApplyingBatch = false; applyingBatch = false;
} }
return result; return result;
} }

6
app/src/main/java/org/fdroid/fdroid/views/apps/AppListItemState.java
View File

@ -21,7 +21,7 @@ public class AppListItemState {
private int progressMax = -1; private int progressMax = -1;
private boolean showInstallButton; private boolean showInstallButton;
private boolean showCheckBox; private boolean showCheckBox;
private boolean isCheckBoxChecked; private boolean checkBoxChecked;
public AppListItemState(@NonNull App app) { public AppListItemState(@NonNull App app) {
this.app = app; this.app = app;
@ -124,7 +124,7 @@ public class AppListItemState {
} }
public boolean isCheckBoxChecked() { public boolean isCheckBoxChecked() {
return isCheckBoxChecked; return checkBoxChecked;
} }
/** /**
@ -133,7 +133,7 @@ public class AppListItemState {
*/ */
public AppListItemState setCheckBoxStatus(boolean checked) { public AppListItemState setCheckBoxStatus(boolean checked) {
this.showCheckBox = true; this.showCheckBox = true;
this.isCheckBoxChecked = checked; this.checkBoxChecked = checked;
return this; return this;
} }

4
app/src/test/java/org/fdroid/fdroid/updater/Issue763MultiRepo.java
View File

@ -35,7 +35,7 @@ public class Issue763MultiRepo extends MultiIndexUpdaterTest {
} }
@Test @Test
public void antoxRepo() throws IndexUpdater.UpdateException { public void testAntoxRepo() throws IndexUpdater.UpdateException {
assertAntoxEmpty(); assertAntoxEmpty();
setEnabled(microGRepo, true); setEnabled(microGRepo, true);
updateAntox(); updateAntox();
@ -47,7 +47,7 @@ public class Issue763MultiRepo extends MultiIndexUpdaterTest {
} }
@Test @Test
public void microGRepo() throws IndexUpdater.UpdateException { public void testMicroGRepo() throws IndexUpdater.UpdateException {
assertMicroGEmpty(); assertMicroGEmpty();
setEnabled(microGRepo, true); setEnabled(microGRepo, true);
updateMicroG(); updateMicroG();