Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CodeStyle : Fixed inconsistent variable name, changed mctx to mCtx

Browse Source
This commit is contained in:
Paresh Chouhan 2016-03-07 23:51:22 +05:30
parent 35e791543a
commit c5aa3f91b1
1 changed files with 27 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
F-Droid/src/org/fdroid/fdroid/AppDetails.java
View File

@ -167,7 +167,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
class ApkListAdapter extends ArrayAdapter<Apk> { class ApkListAdapter extends ArrayAdapter<Apk> {
private final LayoutInflater mInflater = (LayoutInflater) mctx.getSystemService( private final LayoutInflater mInflater = (LayoutInflater) context.getSystemService(
Context.LAYOUT_INFLATER_SERVICE); Context.LAYOUT_INFLATER_SERVICE);
ApkListAdapter(Context context, App app) { ApkListAdapter(Context context, App app) {
@ -192,7 +192,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
// Installed the same version, but from someplace else. // Installed the same version, but from someplace else.
final String installerPkgName; final String installerPkgName;
try { try {
installerPkgName = mPm.getInstallerPackageName(app.packageName); installerPkgName = packageManager.getInstallerPackageName(app.packageName);
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
Log.w(TAG, "Application " + app.packageName + " is not installed anymore"); Log.w(TAG, "Application " + app.packageName + " is not installed anymore");
return getString(R.string.app_not_installed); return getString(R.string.app_not_installed);
@ -201,14 +201,14 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
return getString(R.string.app_inst_unknown_source); return getString(R.string.app_inst_unknown_source);
} }
final String installerLabel = InstalledAppProvider final String installerLabel = InstalledAppProvider
.getApplicationLabel(mctx, installerPkgName); .getApplicationLabel(context, installerPkgName);
return getString(R.string.app_inst_known_source, installerLabel); return getString(R.string.app_inst_known_source, installerLabel);
} }
@Override @Override
public View getView(int position, View convertView, ViewGroup parent) { public View getView(int position, View convertView, ViewGroup parent) {
java.text.DateFormat df = DateFormat.getDateFormat(mctx); java.text.DateFormat df = DateFormat.getDateFormat(context);
final Apk apk = getItem(position); final Apk apk = getItem(position);
ViewHolder holder; ViewHolder holder;
@ -324,17 +324,17 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
private static final int SEND_VIA_BLUETOOTH = Menu.FIRST + 6; private static final int SEND_VIA_BLUETOOTH = Menu.FIRST + 6;
private App app; private App app;
private PackageManager mPm; private PackageManager packageManager;
private ApkDownloader downloadHandler; private ApkDownloader downloadHandler;
private LocalBroadcastManager localBroadcastManager; private LocalBroadcastManager localBroadcastManager;
private boolean startingIgnoreAll; private boolean startingIgnoreAll;
private int startingIgnoreThis; private int startingIgnoreThis;
private final Context mctx = this; private final Context context = this;
private Installer installer; private Installer installer;
private AppDetailsHeaderFragment mHeaderFragment; private AppDetailsHeaderFragment headerFragment;
/** /**
* Stores relevant data that we want to keep track of when destroying the activity * Stores relevant data that we want to keep track of when destroying the activity
@ -388,9 +388,9 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
setTitle(intent.getStringExtra(EXTRA_FROM)); setTitle(intent.getStringExtra(EXTRA_FROM));
} }
mPm = getPackageManager(); packageManager = getPackageManager();
installer = Installer.getActivityInstaller(this, mPm, myInstallerCallback); installer = Installer.getActivityInstaller(this, packageManager, myInstallerCallback);
// Get the preferences we're going to use in this Activity... // Get the preferences we're going to use in this Activity...
ConfigurationChangeHelper previousData = (ConfigurationChangeHelper) getLastCustomNonConfigurationInstance(); ConfigurationChangeHelper previousData = (ConfigurationChangeHelper) getLastCustomNonConfigurationInstance();
@ -474,9 +474,9 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
downloadHandler.setProgressListener(this); downloadHandler.setProgressListener(this);
if (downloadHandler.getTotalBytes() == 0) { if (downloadHandler.getTotalBytes() == 0) {
mHeaderFragment.startProgress(); headerFragment.startProgress();
} else { } else {
mHeaderFragment.updateProgress(downloadHandler.getBytesRead(), downloadHandler.getTotalBytes()); headerFragment.updateProgress(downloadHandler.getBytesRead(), downloadHandler.getTotalBytes());
} }
} }
} }
@ -488,7 +488,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
private void cleanUpFinishedDownload() { private void cleanUpFinishedDownload() {
if (downloadHandler != null) { if (downloadHandler != null) {
downloadHandler.removeProgressListener(); downloadHandler.removeProgressListener();
mHeaderFragment.removeProgress(); headerFragment.removeProgress();
downloadHandler = null; downloadHandler = null;
} }
} }
@ -523,14 +523,14 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
downloadHandler.removeProgressListener(); downloadHandler.removeProgressListener();
} }
mHeaderFragment.removeProgress(); headerFragment.removeProgress();
} }
private final BroadcastReceiver downloaderProgressReceiver = new BroadcastReceiver() { private final BroadcastReceiver downloaderProgressReceiver = new BroadcastReceiver() {
@Override @Override
public void onReceive(Context context, Intent intent) { public void onReceive(Context context, Intent intent) {
if (mHeaderFragment != null) { if (headerFragment != null) {
mHeaderFragment.updateProgress(intent.getIntExtra(Downloader.EXTRA_BYTES_READ, -1), headerFragment.updateProgress(intent.getIntExtra(Downloader.EXTRA_BYTES_READ, -1),
intent.getIntExtra(Downloader.EXTRA_TOTAL_BYTES, -1)); intent.getIntExtra(Downloader.EXTRA_TOTAL_BYTES, -1));
} }
} }
@ -614,10 +614,10 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
} }
private void refreshHeader() { private void refreshHeader() {
mHeaderFragment = (AppDetailsHeaderFragment) headerFragment = (AppDetailsHeaderFragment)
getSupportFragmentManager().findFragmentById(R.id.header); getSupportFragmentManager().findFragmentById(R.id.header);
if (mHeaderFragment != null) { if (headerFragment != null) {
mHeaderFragment.updateViews(); headerFragment.updateViews();
} }
} }
@ -629,7 +629,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
return true; return true;
} }
if (mPm.getLaunchIntentForPackage(app.packageName) != null && app.canAndWantToUpdate()) { if (packageManager.getLaunchIntentForPackage(app.packageName) != null && app.canAndWantToUpdate()) {
MenuItemCompat.setShowAsAction(menu.add( MenuItemCompat.setShowAsAction(menu.add(
Menu.NONE, LAUNCH, 1, R.string.menu_launch) Menu.NONE, LAUNCH, 1, R.string.menu_launch)
.setIcon(R.drawable.ic_play_arrow_white), .setIcon(R.drawable.ic_play_arrow_white),
@ -673,7 +673,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
private void tryOpenUri(String s) { private void tryOpenUri(String s) {
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(s)); Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(s));
if (intent.resolveActivity(mPm) == null) { if (intent.resolveActivity(packageManager) == null) {
Toast.makeText(this, Toast.makeText(this,
getString(R.string.no_handler_app, intent.getDataString()), getString(R.string.no_handler_app, intent.getDataString()),
Toast.LENGTH_LONG).show(); Toast.LENGTH_LONG).show();
@ -887,7 +887,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
new IntentFilter(Downloader.LOCAL_ACTION_PROGRESS)); new IntentFilter(Downloader.LOCAL_ACTION_PROGRESS));
downloadHandler.setProgressListener(this); downloadHandler.setProgressListener(this);
if (downloadHandler.download()) { if (downloadHandler.download()) {
mHeaderFragment.startProgress(); headerFragment.startProgress();
} }
} }
@ -916,7 +916,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
@Override @Override
public void run() { public void run() {
if (operation == Installer.InstallerCallback.OPERATION_INSTALL) { if (operation == Installer.InstallerCallback.OPERATION_INSTALL) {
PackageManagerCompat.setInstaller(mPm, app.packageName); PackageManagerCompat.setInstaller(packageManager, app.packageName);
} }
onAppChanged(); onAppChanged();
@ -966,7 +966,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
}; };
private void launchApk(String packageName) { private void launchApk(String packageName) {
Intent intent = mPm.getLaunchIntentForPackage(packageName); Intent intent = packageManager.getLaunchIntentForPackage(packageName);
startActivity(intent); startActivity(intent);
} }
@ -1015,8 +1015,8 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
} }
if (finished) { if (finished) {
if (mHeaderFragment != null) { if (headerFragment != null) {
mHeaderFragment.removeProgress(); headerFragment.removeProgress();
} }
downloadHandler = null; downloadHandler = null;
} }
@ -1611,7 +1611,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
btMain.setText(R.string.menu_upgrade); btMain.setText(R.string.menu_upgrade);
} else { } else {
updateWanted = false; updateWanted = false;
if (activity.mPm.getLaunchIntentForPackage(app.packageName) != null) { if (activity.packageManager.getLaunchIntentForPackage(app.packageName) != null) {
btMain.setText(R.string.menu_launch); btMain.setText(R.string.menu_launch);
} else { } else {
btMain.setText(R.string.menu_uninstall); btMain.setText(R.string.menu_uninstall);
@ -1649,7 +1649,7 @@ public class AppDetails extends AppCompatActivity implements ProgressListener, A
} }
if (installed) { if (installed) {
// If installed // If installed
if (activity.mPm.getLaunchIntentForPackage(app.packageName) != null) { if (activity.packageManager.getLaunchIntentForPackage(app.packageName) != null) {
// If "launchable", launch // If "launchable", launch
activity.launchApk(app.packageName); activity.launchApk(app.packageName);
} else { } else {