Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PMD: Enable most empty code rules

Browse Source
This commit is contained in:
Daniel Martí 2016-05-12 10:50:12 +01:00
parent 65e2931fe8
commit c432bf1ea0
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/fdroid/fdroid/views/swap/SwapAppsView.java
View File

@ -96,10 +96,12 @@ public class SwapAppsView extends ListView implements
super.onFinishInflate(); super.onFinishInflate();
repo = getActivity().getState().getPeerRepo(); repo = getActivity().getState().getPeerRepo();
/*
if (repo == null) { if (repo == null) {
// TODO: Uh oh, something stuffed up for this to happen. TODO: Uh oh, something stuffed up for this to happen.
// TODO: What is the best course of action from here? TODO: What is the best course of action from here?
} }
*/
adapter = new AppListAdapter(getContext(), getContext().getContentResolver().query( adapter = new AppListAdapter(getContext(), getContext().getContentResolver().query(
AppProvider.getRepoUri(repo), AppProvider.DataColumns.ALL, null, null, null)); AppProvider.getRepoUri(repo), AppProvider.DataColumns.ALL, null, null, null));

4
config/pmd/rules.xml
View File

@ -17,6 +17,10 @@
<rule ref="rulesets/java/unnecessary.xml"> <rule ref="rulesets/java/unnecessary.xml">
<exclude name="UselessParentheses"/> <!--Too nitpicky--> <exclude name="UselessParentheses"/> <!--Too nitpicky-->
</rule> </rule>
<rule ref="rulesets/java/empty.xml">
<exclude name="EmptyCatchBlock"/> <!--Ignoring an exception-->
<exclude name="EmptyWhileStmt"/> <!--Can be useful sometimes-->
</rule>
<rule ref="rulesets/java/optimizations.xml/PrematureDeclaration"/> <rule ref="rulesets/java/optimizations.xml/PrematureDeclaration"/>
<rule ref="rulesets/java/optimizations.xml/AddEmptyString"/> <rule ref="rulesets/java/optimizations.xml/AddEmptyString"/>
<rule ref="rulesets/java/optimizations.xml/UseArraysAsList"/> <rule ref="rulesets/java/optimizations.xml/UseArraysAsList"/>