From bb88be9403bf38dd16a1bd060cad4d4a121c9694 Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Thu, 4 Aug 2016 10:50:22 +1000 Subject: [PATCH] Further tests for AppPrefs.equals() which is used by AppDetails. --- .../fdroid/fdroid/data/AppPrefsProviderTest.java | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/app/src/test/java/org/fdroid/fdroid/data/AppPrefsProviderTest.java b/app/src/test/java/org/fdroid/fdroid/data/AppPrefsProviderTest.java index 128f52cb2..150e99f99 100644 --- a/app/src/test/java/org/fdroid/fdroid/data/AppPrefsProviderTest.java +++ b/app/src/test/java/org/fdroid/fdroid/data/AppPrefsProviderTest.java @@ -26,6 +26,21 @@ public class AppPrefsProviderTest extends FDroidProviderTest { ShadowContentResolver.registerProvider(AppProvider.getAuthority(), new AppProvider()); } + @SuppressWarnings({"PMD.EqualsNull", "EqualsWithItself", "EqualsBetweenInconvertibleTypes", "ObjectEqualsNull"}) + @Test + public void prefEquality() { + AppPrefs original = new AppPrefs(101, true); + + assertTrue(original.equals(new AppPrefs(101, true))); + assertTrue(original.equals(original)); + + assertFalse(original.equals(null)); + assertFalse(original.equals("String")); + assertFalse(original.equals(new AppPrefs(102, true))); + assertFalse(original.equals(new AppPrefs(101, false))); + assertFalse(original.equals(new AppPrefs(100, false))); + } + @Test public void newPreferences() { App withPrefs = Assert.insertApp(context, "com.example.withPrefs", "With Prefs");