Karl/BobStore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

better report failing plurals tests

Browse Source
This commit is contained in:
Hans-Christoph Steiner 2017-06-16 00:09:31 +02:00
parent 53a17e6146
commit bb47d1e41e
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/androidTest/java/org/fdroid/fdroid/LocalizationTest.java
View File

@ -99,13 +99,14 @@ public class LocalizationTest {
// Resources() requires DisplayMetrics, but they are only needed for drawables // Resources() requires DisplayMetrics, but they are only needed for drawables
resources = new Resources(assets, new DisplayMetrics(), config); resources = new Resources(assets, new DisplayMetrics(), config);
for (Field field : fields) { for (Field field : fields) {
String formats = null;
try {
int resId = field.getInt(int.class); int resId = field.getInt(int.class);
for (int quantity = 0; quantity < 22; quantity++) { for (int quantity = 0; quantity < 22; quantity++) {
resources.getQuantityString(resId, quantity); resources.getQuantityString(resId, quantity);
} }
String formats = haveFormats.get(field.getName()); formats = haveFormats.get(field.getName());
try {
switch (formats) { switch (formats) {
case "d": case "d":
resources.getQuantityString(resId, 1, 1); resources.getQuantityString(resId, 1, 1);
@ -121,7 +122,7 @@ public class LocalizationTest {
throw new IllegalStateException("Pattern not included in tests: " + formats); throw new IllegalStateException("Pattern not included in tests: " + formats);
} }
} }
} catch (IllegalFormatException e) { } catch (IllegalFormatException | Resources.NotFoundException e) {
Log.i(TAG, locale + " " + field.getName()); Log.i(TAG, locale + " " + field.getName());
throw new IllegalArgumentException("Bad '" + formats + "' format in " + locale + " " throw new IllegalArgumentException("Bad '" + formats + "' format in " + locale + " "
+ field.getName() + ": " + e.getMessage()); + field.getName() + ": " + e.getMessage());