From ba54e8b798254a857a5fe011a592fc7a7cfde444 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sun, 9 Aug 2015 22:47:48 -0700 Subject: [PATCH] SystemInstaller: don't try to remove system apps without updates --- .../src/org/fdroid/fdroid/installer/SystemInstaller.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/F-Droid/src/org/fdroid/fdroid/installer/SystemInstaller.java b/F-Droid/src/org/fdroid/fdroid/installer/SystemInstaller.java index 0a1cd08e2..f6df282fa 100644 --- a/F-Droid/src/org/fdroid/fdroid/installer/SystemInstaller.java +++ b/F-Droid/src/org/fdroid/fdroid/installer/SystemInstaller.java @@ -193,7 +193,16 @@ public class SystemInstaller extends Installer { return; } + final boolean isSystem = ((appInfo.flags & ApplicationInfo.FLAG_SYSTEM) != 0); final boolean isUpdate = ((appInfo.flags & ApplicationInfo.FLAG_UPDATED_SYSTEM_APP) != 0); + + if (isSystem && !isUpdate) { + // Cannot remove system apps unless we're uninstalling updates + mCallback.onError(InstallerCallback.OPERATION_DELETE, + InstallerCallback.ERROR_CODE_OTHER); + return; + } + int messageId; if (isUpdate) { messageId = R.string.uninstall_update_confirm;