From ba503812e4e312e124420a6e6843acf3528c9cfd Mon Sep 17 00:00:00 2001 From: Peter Serwylo Date: Wed, 22 Mar 2017 13:00:51 +1100 Subject: [PATCH] Don't listen for the same broadcast events twice. Caused crashes when we incorrectly provided info to the recyler view about which items had been added/removed. --- .../java/org/fdroid/fdroid/views/main/MainViewAdapter.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/views/main/MainViewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/main/MainViewAdapter.java index 7731c89c3..aeaf7e775 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/main/MainViewAdapter.java +++ b/app/src/main/java/org/fdroid/fdroid/views/main/MainViewAdapter.java @@ -69,7 +69,8 @@ class MainViewAdapter extends RecyclerView.Adapter { holder.bindSwapView(); break; case R.id.updates: - holder.bindUpdates(); + // Hold of until onViewAttachedToWindow, because that is where we want to start listening + // for broadcast events (which is what the data binding does). break; case R.id.settings: holder.bindSettingsView();