diff --git a/app/src/main/java/org/fdroid/fdroid/Provisioner.java b/app/src/main/java/org/fdroid/fdroid/Provisioner.java index 13464702d..26782111f 100644 --- a/app/src/main/java/org/fdroid/fdroid/Provisioner.java +++ b/app/src/main/java/org/fdroid/fdroid/Provisioner.java @@ -4,9 +4,7 @@ import android.content.Context; import android.content.Intent; import android.net.Uri; import android.util.Base64; - import com.fasterxml.jackson.databind.ObjectMapper; - import org.apache.commons.io.IOUtils; import org.fdroid.fdroid.data.Repo; import org.fdroid.fdroid.data.RepoProvider; @@ -37,7 +35,7 @@ public class Provisioner { /** * This is the name of the subfolder in the file directory of this app * where {@link Provisioner} looks for new provisions. - * + *
* eg. in the Emulator (API level 24): /data/user/0/org.fdroid.fdroid.debug/files/provisions
*/
private static final String NEW_PROVISIONS_DIR = "provisions";
@@ -48,7 +46,7 @@ public class Provisioner {
/**
* search for provision files and process them
*/
- public static void scanAndProcess(Context context) {
+ static void scanAndProcess(Context context) {
File externalFilesDir = context.getExternalFilesDir(null);
if (externalFilesDir == null) {
return;
@@ -83,21 +81,24 @@ public class Provisioner {
Uri origUrl = Uri.parse(repo.getUrl());
Uri.Builder data = new Uri.Builder();
data.scheme(origUrl.getScheme());
- data.encodedAuthority(Uri.encode(repo.getUsername()) + ":" + Uri.encode(repo.getPassword()) + "@" + Uri.encode(origUrl.getAuthority()));
+ data.encodedAuthority(Uri.encode(repo.getUsername()) + ':'
+ + Uri.encode(repo.getPassword()) + '@' + Uri.encode(origUrl.getAuthority()));
data.path(origUrl.getPath());
data.appendQueryParameter("fingerprint", repo.getSigfp());
Intent i = new Intent(context, ManageReposActivity.class);
i.setData(data.build());
context.startActivity(i);
- Utils.debugLog(TAG, "Provision processed: '" + provision.getProvisonPath() + "' prompted user ...");
+ Utils.debugLog(TAG, "Provision processed: '"
+ + provision.getProvisonPath() + "' prompted user ...");
}
}
// remove provision file
try {
- new File(provision.getProvisonPath()).delete();
- cleanupCounter++;
+ if (new File(provision.getProvisonPath()).delete()) {
+ cleanupCounter++;
+ }
} catch (SecurityException e) {
// ignore this exception
Utils.debugLog(TAG, "Removing provision not possible: " + e.getMessage() + " ()");
@@ -108,7 +109,7 @@ public class Provisioner {
}
}
- public List